Comments (5)
I modified the issue title because we don't have a listenAfter
API.
Eh ... ok. I get it. But why are you rendering in listenBefore
? That's your cue that "things might change, we're not sure yet". Seems much safer to run your code in the listen
callback.
from history.
Apologies for the incorrect title.
You're right, what we're doing in listenBefore
in this instance is a hack to maintain use case that was easily achieved with react-router v1.0.0-beta3.
I maintain that it's reasonable to expect a history API that offers a listenBefore
hook to fire those callbacks on browser navigation regardless of whether a different listener is also registered. Disagree?
from history.
it's reasonable to expect a history API that offers a listenBefore hook to fire those callbacks on browser navigation regardless of whether a different listener is also registered
Ya, that's reasonable. But your use case is still invalid. I'd much prefer to drive further development with valid use cases instead of theory. If there's a good reason why you're using listenBefore
instead of listen
for rendering, I'd like to know.
EDIT: I should also say that I'm open to fixing this. Just want to know why you're using listenBefore
instead of listen
.
from history.
The linked project uses listenBefore
instead of listen
in order to fetch the data required for the next routes before the location bar is updated. You say this use case is invalid and I have agreed although I note that there are others who do want this use case: https://twitter.com/gpblv/status/650249197950738432
I didn't create this ticket to drive further development, just to address what I see is an issue with this project. I maintain that listenBefore
handlers should always be called, although I don't have a real-world use case.
IMO the code should be changed or a warning added to the docs as neither of the examples here would work without a listen
handler also added: https://github.com/rackt/history/blob/master/docs/ConfirmingNavigation.md
Like I say, let me know if you want a PR otherwise I'll close this issue.
from history.
You have a great point about the docs. Sure, let's make this change. A PR would be great, thanks for offering :)
In order to make this change you'll need to override listenBefore
in both createBrowserHistory
and createHashHistory
. Currently, both of those implementations override listen
to know when they need to setup/teardown DOM event listeners.
from history.
Related Issues (20)
- Named exports donβt work with Node.js ESM support HOT 1
- Sourcemaps are blank HOT 1
- Use History in redux actions HOT 2
- Location type should have template for unknown for state HOT 3
- doing history.go() does NOT trigger a blocker callback handler HOT 1
- Did TS declaration file disappear for v4? HOT 4
- Wrong action after clicking on Forward button in browser HOT 3
- Need history.BackTo(string)
- Is it possible to access the history bundled into React Router? HOT 1
- globalHistory.pushState function excuted failed in baidu.app
- [v6] Missing hashType={"noslash"} of HashRouter HOT 3
- [react-router-dom v6] HashRouter support HOT 1
- Add index property to BrowserHistory, HashHistory and corresponding Update
- Why `history.length` is gone? HOT 7
- createBrowserHistory() breaks history URL on iOS 11
- history
- is this project abandoned? HOT 2
- Navigate replace without generate new location.key
- hash history url is not parsed correctly with query params
- ReferenceError: document is not defined in Next.JS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from history.