GithubHelp home page GithubHelp logo

Comments (2)

mjackson avatar mjackson commented on April 19, 2024

That makes sense only insofar as your URLs are unique to the extra state you provide (i.e. the state argument to pushState). Otherwise you risk unintentionally overwriting state from the last time the user visited a certain URL. To avoid this ambiguity (and to save some poor developer having to troubleshoot this for hours in the future) I'd rather not use the URL as a location.key.

Also, just a quick note about disabling queryKey: don't do it. Everyone has been asking about it, but the default is there so your stuff doesn't break.

from history.

taion avatar taion commented on April 19, 2024

Fair enough. I guess this isn't safe as a default. Do you think it's worth offering as a non-default option? I'm asking here because it doesn't seem like there's a straightforward way to e.g. extend createHashHistory in my own code to enable this pattern.

from history.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.