Comments (3)
Passing a generic for location.state used to give a generic (see history/api-reference)
The generic was removed in this commit.
location.state
is likelocation.search
, there's no way for a type system to do its job with a value that isn't controlled by the code. Similarly, the DOM type forURLSearchParams
is not generic. And the built-in types forwindow.history.state
isany
without a generic. The only way to type checklocation.state
orlocation.search
or really any value onlocation.*
is to do it at runtime and then get type hints from using type guards.
from history.
I thinks it's a good idea
from history.
@elijahrdorman Seconded. This temporarily fixed the problem for me with the Class hoc:
export interface ILocationState<Type> extends Omit<Location, 'state'> { state: any | Type };
export interface IWithRouter<Type = any> { //TODO: make this a mandatory Type so it's easier to keep track of State between components.
router: {
location: ILocationState<Type>;
navigate: NavigateFunction;
params: Readonly<Params<string>>;
}
}
};
Usage:
- Class:
interface IComponentProps extends IBlablaProps, IWithRouter<{ fooBar: string }> { }
- Functional:
const location = useLocation() as ILocationState<{ fooBar: string }>;
from history.
Related Issues (20)
- Named exports donβt work with Node.js ESM support HOT 1
- Sourcemaps are blank HOT 1
- Use History in redux actions HOT 2
- doing history.go() does NOT trigger a blocker callback handler HOT 1
- Did TS declaration file disappear for v4? HOT 4
- Wrong action after clicking on Forward button in browser HOT 3
- Need history.BackTo(string)
- Is it possible to access the history bundled into React Router? HOT 1
- globalHistory.pushState function excuted failed in baidu.app
- [v6] Missing hashType={"noslash"} of HashRouter HOT 3
- [react-router-dom v6] HashRouter support HOT 1
- Add index property to BrowserHistory, HashHistory and corresponding Update
- Why `history.length` is gone? HOT 7
- createBrowserHistory() breaks history URL on iOS 11
- history
- is this project abandoned? HOT 2
- Navigate replace without generate new location.key
- hash history url is not parsed correctly with query params
- ReferenceError: document is not defined in Next.JS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from history.