Cypress fails on CI (github action) about indie-stack

[MichaelDeBoey]

Closed by #102

[MichaelDeBoey]

Will probably be fixed by #102

[AsaAyers]

I don't think this fully fixed it 😢 I just created a new project by running npx create-remix --template remix-run/indie-stack and following the readme. npm ci works locally but fails on CI.

[AsaAyers]

This got me past that npm ci error.

index d01b1b0..a45574c 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -100,7 +100,7 @@ jobs:
       - name: 📥 Download deps
         uses: bahmutov/npm-install@v1
         with:
-          useLockFile: false
+          useLockFile: true
 
       - name: 🛠 Setup Database
         run: npx prisma migrate reset --force

[mcansh]

ah yep, the first run won't have a lock file until the deps are installed due to #79, so npm ci will fail, personally i think it's fine to have them by default and if someone wants to use a diff package manager, they'll know what to do - especially because we still use npm in the Dockerfile

[machour]

@mcansh Could we add some output to the CI about this to avoid confusing users?

[mcansh]

something like? I'm not sure this is better than just having one by default as we still use npm in the Dockerfile

- name: Check for lockfile
  run: |
    FILE=package-lock.json
    if [ ! -f "$FILE" ]; then
      echo "$FILE does not exist. Please run `npm install` before continuing"
      exit 1
    fi

however! just thought about this, we could potentially check for the package manager in github and pass that to Docker for it to know which files to copy and which PM to use 🤔

[AsaAyers]

I did "npm install" first. I did have a package-lock.json. The step that's failing is complaining the lock file is out of sync. I was able to fix that by adjusting an earlier step and telling it to use the lock file to check out the dependencies. I think by explicitly disabling the lock file, it would check out different versions of packages and then that cuses "npm ci" to complain about them being out of sync.

…

On Fri, Jun 10, 2022, 8:15 AM Logan McAnsh ***@***.***> wrote: something like? I'm not sure this is better than just having one by default as we still use npm in the Dockerfile - name: Check for lockfile run: | FILE=package-lock.json if [ ! -f "$FILE" ]; then echo "$FILE does not exist. Please run `npm install` before continuing" exit 1 fi — Reply to this email directly, view it on GitHub <#103 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACPLB3CE2KAKZNQRYCKLL3VONLYFANCNFSM5YJ22BFQ> . You are receiving this because you commented.Message ID: ***@***.***>

[mcansh]

I think by explicitly disabling the lock file, it would check out different versions of packages and then that causes "npm ci" to complain about them being out of sync.

something is definitely up, but i don't think that's it as opting out of the lock file uses npm install and not npm ci

https://github.com/bahmutov/npm-install/blob/master/index.js#L112

[mcansh]

interesting, i just created a new app and the cypress job passed https://github.com/mcansh/indie-stack-test/runs/6971217149?check_suite_focus=true

[machour]

Closing this issue as no response was provided.
Feel free to re-open it if it's still a problem.