Comments (9)
Makes sense. Interested in helping out? The GitHub Actions build the packages and would need to be changed for that so they include the LICENSE in the targz files.
from mob.
Sorry, I'm not that firm with Github Actions yet.
F.ex. I am not sure if I have to setup things like Secrets etc to get something like this up and running in my fork...
from mob.
Maybe it's sufficient to replace L35 in https://github.com/draptik/mob/blob/master/.github/workflows/release.yaml?
Before:
file: "*{.tar.gz,_checksum.txt}"
After:
file: "*{.tar.gz,_checksum.txt,LICENSE}"
Completely untested, just guessing ;-)
from mob.
Not sure. Maybe the GitHub Action plugin that’s being used should be looked at.
from mob.
I had a look, the https://github.com/remotemobprogramming/mob/blob/master/.github/build is responsible for creating the .tar.gz file. As far as I understand it, you want to have the LICENSE file inside the .tar.gz file, right? If so, one would need modify this shell script at .github/build
to add it.
from mob.
Thanks for finding the correct location to change!
I'll create a pull request.
from mob.
Not sure, however, what the install procedure now will do at https://github.com/remotemobprogramming/mob/blob/master/install.sh#L111 with the additional file available. In the worst case scenario, we would add a license file to /usr/local/bin/. We should make sure this won't happen. Can you have a look at how we can prevent that?
from mob.
The install.sh script already does everything correctly:
curl -sSL "$url" | tar xz -C "$target" "$(determine_mob_binary)" && chmod +x "$target"/mob
The part curl ... | tar xz -C "$target" "$(determine_mob_binary)"
only extracts the binary, so other files (i.e. LICENSE) are not extracted to the target location.
I verified with the following test:
mkdir -p ~/tmp/mob-test/target
curl -sSL https://github.com/remotemobprogramming/mob/archive/v1.1.0.tar.gz | tar xz -C ~/tmp/mob-test/target/ mob-1.1.0/README.md
The above command will only extract the README.md
file.
from mob.
Thanks for verifying that! I'll close the ticket as it's done.
Thanks again for making this feature happen.
from mob.
Related Issues (20)
- missing sha in Arch PKGBUILD in v4.4.3 HOT 5
- Doesn't run on Debian 10 HOT 6
- Allow specify mob timer room by cli option
- MOB_GIT_HOOKS_ENABLED not respected? HOT 2
- Errors when branch name contains a dash HOT 5
- Exits with 0 on at least some failures HOT 3
- Go version and mob version when installing with go tools are outdated HOT 1
- Windows Build with UPX Packer HOT 1
- Remove cancellation of the local mob timer when doing mob done or mob next HOT 2
- Empty Commit when starting a new session leads to problems
- Add support for gerrit HOT 6
- mob status should show if a mob session exists HOT 2
- Better Tutorial
- brew install for linux
- Interactive configuration mode HOT 1
- Feature Request: Hooks to extend `mob` by running custom commands HOT 1
- Was there a re-release? HOT 17
- allow mob next with message commit to still have the CI skip flag HOT 1
- MOB_SKIP_CI_PUSH_OPTION_ENABLED is evaluated incorrectly HOT 2
- windows defender is marking 'Wacatac.B!ml' file as a trojan HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mob.