feature request: add license to binary tarball about mob

[simonharrer]

Makes sense. Interested in helping out? The GitHub Actions build the packages and would need to be changed for that so they include the LICENSE in the targz files.

[draptik]

Sorry, I'm not that firm with Github Actions yet.
F.ex. I am not sure if I have to setup things like Secrets etc to get something like this up and running in my fork...

[draptik]

Maybe it's sufficient to replace L35 in https://github.com/draptik/mob/blob/master/.github/workflows/release.yaml?

Before:

file: "*{.tar.gz,_checksum.txt}"

After:

file: "*{.tar.gz,_checksum.txt,LICENSE}"

Completely untested, just guessing ;-)

[simonharrer]

Not sure. Maybe the GitHub Action plugin that’s being used should be looked at.

[simonharrer]

I had a look, the https://github.com/remotemobprogramming/mob/blob/master/.github/build is responsible for creating the .tar.gz file. As far as I understand it, you want to have the LICENSE file inside the .tar.gz file, right? If so, one would need modify this shell script at .github/build to add it.

[draptik]

Thanks for finding the correct location to change!
I'll create a pull request.

[simonharrer]

Not sure, however, what the install procedure now will do at https://github.com/remotemobprogramming/mob/blob/master/install.sh#L111 with the additional file available. In the worst case scenario, we would add a license file to /usr/local/bin/. We should make sure this won't happen. Can you have a look at how we can prevent that?

[draptik]

The install.sh script already does everything correctly:

curl -sSL "$url" | tar xz -C "$target" "$(determine_mob_binary)" && chmod +x "$target"/mob

The part curl ... | tar xz -C "$target" "$(determine_mob_binary)" only extracts the binary, so other files (i.e. LICENSE) are not extracted to the target location.

I verified with the following test:

mkdir -p ~/tmp/mob-test/target
curl -sSL https://github.com/remotemobprogramming/mob/archive/v1.1.0.tar.gz | tar xz -C ~/tmp/mob-test/target/ mob-1.1.0/README.md

The above command will only extract the README.md file.

[simonharrer]

Thanks for verifying that! I'll close the ticket as it's done.

Thanks again for making this feature happen.