Comments (3)
LinusBorg
commented on July 27, 2024
This limitation of my portal-vue lib was one of the reasons that I later created https://github.com/LinusBorg/vue-simple-portal
It's aimed precisely at the use case of components that only need to be moved ot the bottom of the <body> element's children and doesn't have the limitation concerning inject and $parent.
So maybe give it a try. As a bonus, it's much lighter than portal-vue. And closer to how the native teleport in Vue 3 works.
from a11y-vue-dialog.
renatodeleao
commented on July 27, 2024
@LinusBorg thanks for stopping by, it's not everyday that you have core vue members around!
I must admit that I was not aware of that "lite" version, i'll make sure to give it a spin, and include a reference in the docs as a suggestion for people who might be using provide/inject with this component.
Not sure if you seen it, but I was actually thinking about making this component portal-agnostic #11: although I strongly suggest and recommend using a portal implementation for dialogs (particularly yours), i'm thinking about not including portal-vue as an explicit dependency since this should allegedly work with all portal-vue versions (including that simple one) and any other portal implementations (not that i'm aware of any other actual alternative to portal-vue to be honest, but devs like to have their own things), so your comment gives an extra push to that idea.
Lastly many thanks for portal-vue been using it almost since my day one in vueland.
Cheers!
from a11y-vue-dialog.
LinusBorg
commented on July 27, 2024
Sound like a good plan.
And thanks for the kind words :)
from a11y-vue-dialog.
Related Issues (14)
- Remove portal-vue dependency
- Refactor markup version o dialog to use the renderless as base HOT 1
- PreventBackgroundScroll is too opinionated HOT 2
- Breaks focus trap when v-if not applied to portal HOT 1
- Using <transition> and applying v-if to dialogRoot ref breaks focus trap HOT 1
- fix: dialogRef flaky specs HOT 1
- remove: closeFn scope property.
- We wrongly assume that backdropRef will be dialogs root
- If we remove focused element on async action, then dialog doesn't close on escape
- Focus trap 3.0 HOT 1
- bug: breaks if using focus-visibile polyfill
- Automate packaging/publishing/releases
- Replace vuepress with vitepress
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from a11y-vue-dialog.