renatodeleao / a11y-vue-dialog Goto Github PK
View Code? Open in Web Editor NEWAn accessibility-first renderless (headless) dialog component made for Vue https://renatodeleao.github.io/a11y-vue-dialog/
License: MIT License
An accessibility-first renderless (headless) dialog component made for Vue https://renatodeleao.github.io/a11y-vue-dialog/
License: MIT License
and errors... ๐ต๏ธ
Although things are working i can't seem to write a proper test to check if methods are being called correctly.
A know limitation of portal-vue
so while this depends on it we should warn users.
Gladely vue 3 new <Teleport />
won't have these issues
although I still recommend a portal solution for accessible dialogs, and speciallyportal-vue
as the one till Vue 3 comes out and we have <Teleport>
, i don't want to list it under our dependencies anymore, since we're moving renderless and any portal solution should, in theory, work.
The portal
version itself should not have any influence on this component behaviour, and any current portal version should work anyways.
Since we use <component :is="portalName" />
under the hood for the markuped, it should be fairly easy to provide any valid portal component name and props object for configuration.
Also as announced, the markup version of this component be deprecated, so it makes even more sense to do it.
This assumption needs some testing of course.
Note that this is not a security concern for the package at all, but I'm tired of getting those weekly security emails from github.
Vuepress
has been deprecated and Vitpress
is the new king in town.
It doesn't make sense to have the same logic twice.
This came from the one to one match of the markup version:
<a11y-vue-dialog-renderless #default="{ backdropRef }">
<!-- i work as root but also as backdrop overlay -->
<div class="dialog" v-bind="backdropRef.props">
<div class="dialog__inner">conent</div>
<div>
</div>
But this is also a valid implementation, and currently will break the component
<a11y-vue-dialog-renderless #default="{ backdropRef }">
<!-- i work as root -->
<div class="dialog">
<div class="dialog__backdrop" v-bind="backdropRef.props" />
<div class="dialog__inner">conent</div>
<div>
</div>
Our dom "refs", are querySelected
assuming a dialogRoot exists and is the element with data-id
, but that data-id
is bound via backdropRef.props
, meaning it won't find the descendents.
a11y-vue-dialog/src/A11yVueDialogRenderless.vue
Lines 176 to 188 in 34f5985
This plugin shouldn't try to guess Apps root dom structure. Remove $root
overflow declaration. Make it optional to pass a scrollableElement other than body
but don't infer it.
it's a duplicate of closeRef.listeners.click
and it's making the scoped slots API bigger for no extra benefit.
After v0.4.6, we get it stable enough to not break code, but there's sill some scenarios were the calculation of what's the previous
or next
Tab-able element fails.
The good news is, focus is still trapped within dialog after content mutations, it still gets new focusable elements, so no functionality was broke.
I'll pick on this next month.
And also when dialog starts open by default, focus element is not found
Because there's not a focusable element within dialog selected.
We need to re-focus
after the current focus element is removed.
Not sure if the best approach is to focus first or next focusable element. Maybe binding keyboard elements to window instead would do, but then nested dialogs would require extra-logic.
Using :focus-visible polyfill breaks focus trap.
Test and it's reproducible on versions >= 0.4.5
โ so probably that frankenstein engeneering to keep focus trap order after conditional content mutation affected this. The good side is debugging since it reduces the scope of causes.
it's not the first time that i publish a version without actually build code on it. Let's automate the whole process so it doesn't rely on my tired human brain.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.