Comments (7)
Ok, so wrapping them or passing render prop is way to go given limitations of typings
from react-powerplug.
We don't care about the component type definition, this should be a components concern. When something like this happens to me, usually I change the children
to be an optional type:
children?: (RenderProps: WhateverType) => React.ReactNode
So, of course, this can be leaky for powerplug!
What you can do is use the render
prop on mapper:
const Composed = adopt({
toggle: ({ render }) => <Toggle>{render}</Toggle>
})
from react-powerplug.
Yep composition with types sucks. But I wouldn't like to provide leaky types to solve this problem.
from react-powerplug.
It worked with react-apollo, so maybe use the types they use?
from react-powerplug.
I don't see they use anything special.
@pedronauck could you clarify how adopt
can work with apollo and not work with powerplug?
from react-powerplug.
Ah you're right, they basically enforce children prop as well
children: (result: QueryResult<TData, TVariables>) => React.ReactNode;
I was wrapping my queries/mutations which is why the error wasn't appearing
Hmm I wonder if anything can be done about this
from react-powerplug.
React team works on this problem. They probably will suggest a custom syntax like this, so type systems could solve the problem on syntax level.
const counter = adopt <plug.Value initial={0} />
from react-powerplug.
Related Issues (20)
- [Feature Request] <Tabs /> component for Tabs or Carousel. HOT 2
- Toggle documentation outdated HOT 1
- Warning: The prop `children` is marked as required HOT 1
- Currently is a pain to edit flow files in a project HOT 4
- Why are there no control props for the state management components? HOT 3
- Export flow type definitions HOT 6
- Upgrade typescript definition HOT 11
- react-powerplug breaking build after babel 7 upgrade HOT 16
- onMount={props => ...} HOT 2
- Bad English in README HOT 2
- State component - "onChange" question HOT 1
- RFC: ElementContainer HOT 3
- Latest should not point to a release candidate HOT 5
- `State` component implements `Value` component & not the other way around HOT 3
- Wrong types with Flow and react-composer and compose HOT 1
- [Feature Request] React hooks support. HOT 4
- Add access to browser events to feedback containers
- Changing state causes rerender that breaks animations
- Initial Hover state is wrong on load if cursor is over element
- Document site is broken, 404 Not Found HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-powerplug.