Individual imports about react-powerplug

[Andarist]

I can only confirm that generally speaking flat bundling (what rollup does) is better than having a directory structure - it allows for easier tree-shakeability webpack (upcoming webpack@4 might get better at this, but anyway many, many users still use webpack 2 or 3).

There is no reason to allow for package/submodule imports (also setting this up in proper way is quite difficult and there is no tool - that im aware of - at the moment which does it automatically). I see a room for package/flavour though (i.e. unistore/react, unistore/preact), but this library is a set of utilities and as such IMHO it should be accessible from a single entry point.

Having a proper tree-shaking tooling will make proposed import Hover from 'react-powerplug/Hover' and import { Hover } from 'react-powerplug equivalent - exact same code should land in your final bundle.

[renatorib]

Thanks again 😄

For now it's possible to import this way

import Hover from 'react-powerplug/lib/components/Hover'

To make import of react-powerplug/Hover possible, we will need to change the folder structure, OR add some config to rollup that I don't know, but we can search about.

[souporserious]

Oh awesome! That's wonderful 👏 I'll look into it and see if we can make them a litter easier to write, but this works great for now. Thanks for the quick reply!

[renatorib]

You're welcome!

I will leave this issue open, so anyone can help too.

[TrySound]

I would not rely on folder structure. It's bad pattern and tree shaking improvements in the last months can prevent us from it.

[renatorib]

You are right @TrySound.
Do you have some suggestions?

[TrySound]

I tried both rollup and webpack and they both treeshake good. The only side effect now is State component, but it's base component, it always will be if library is used.

[TrySound]

State treeshaking will be available after babel/babel#6963 merge

[renatorib]

Thanks for your explanation @Andarist!

I'll close this issue since v1 will not have a export default (#31), which will help with tree shaking.