GithubHelp home page GithubHelp logo

Comments (7)

gnapse avatar gnapse commented on May 15, 2024 1

Do you want me to work on a PR? I already implemented this exact same functionality in the library I was using internally for this: https://github.com/gnapse/render-props-compose

from react-powerplug.

renatorib avatar renatorib commented on May 15, 2024 1

If you want, feel free to send a PR! 😄

from react-powerplug.

renatorib avatar renatorib commented on May 15, 2024 1

With compose function (w/ current 1.0 behavior), when you do that

const ToggleCounter = compose(Toggle, Counter)

<ToggleCounter>
  {({ toggle, counter }) => (
    <div>...</div>
  )}
</ToggleCounter>

Is the same as doing this:

<Counter>
  {counter => (
    <Toggle>
      {toggle => (
         <div>...</div>
      )}
    </Toggle>
  )}
</Counter>

When Toggle state is changed, only Toggle component will rerendered.
But when Counter stated is changed, all inside it will be rerendered: Counter and Toggle.

Is nothing problematic or dangerous, it's just to document the behavior

from react-powerplug.

renatorib avatar renatorib commented on May 15, 2024

Yea, I like it. I already had this idea in my head for 1.0. I think it's the best way to compose without conflicts.

from react-powerplug.

gnapse avatar gnapse commented on May 15, 2024

@renatorib can you explain to me what this phrase in the README means? I'm a bit lost about it:

Because of that, when you use toggle function, only <Toggle> will be rerendered, but if you use inc or dec functions, both <Counter> and <Toggle> will be rerendered. Even using compose() utility.

It's at the end of the section of the README that talks about the composed components.

from react-powerplug.

gnapse avatar gnapse commented on May 15, 2024

Thanks, yeah, I had misread it a bit and hence I did not fully understand it.

PR submitted BTW, let me know how it's looking when you get the chance.

from react-powerplug.

renatorib avatar renatorib commented on May 15, 2024

No prob! 😄
English is not my native language. Sometimes is hard to turn my thoughts into words/sentences.

If you want to see it in action: https://stackblitz.com/edit/react-pe1ye3
Open console and click toggle button, after click counter button, and see the logs

I'll see your PR soon, thanks!

from react-powerplug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.