Question: Make `GeneratesSnsMessages` a public trait? about laravel-aws-webhooks

[rennokki]

I don't see any problem with a PR for this 😁

[rennokki]

It was placed under the test folder because it is used for development only, as it shouldn't be used in production packages. Usually when you composer install package, the dev autoload still loads it since it wasnt installed with --no-dev

Do you need this in production, like when running composer install --no-dev?

[stefanzweifel]

Do you need this in production, like when running composer install --no-dev?

No, we don't need this in production. I'm using the copy of the GeneratesSnsMessages-trait in the apps test suite. Tests are not run in production. Only on local machines and in the CI environment.

Locally I don't use composer install --no-dev, as I want my dev-dependencies installed. Theoretically composer install (without --no-dev) should add the dev paths of dependencies to the autoloader. But this doesn't seem to work on my machine with the latest composer version. A subsequent composer dump-autoload doesn't help either. 🤔

PHP Fatal error:  Trait 'Rennokki\LaravelSnsEvents\Tests\Concerns\GeneratesSnsMessages' 
not found in /tests/Features/AwsSnsSesWebhookControllerTest.php on line 11

I thought it would be great, if the package could also provide some sort of helper, to make testing ones own Controller easier. But I also totally understand the point of not wanting to add "dev only" code to the published package.
My copy of the trait works fine for me. ☺️

[stefanzweifel]

Thanks for the merge and release!