GithubHelp home page GithubHelp logo

Comments (4)

thomasbiddle avatar thomasbiddle commented on May 22, 2024

Along with this - it would be great to allow a variable to be referenced. I follow the practice of

ENV PORT=3000
EXPOSE $PORT

... (Use in other spots as well, to keep DRY)
Line 18: EXPOSE $PORT
Issue  Category      Title                 Description
    1  Possible Bug  Invalid Port Exposed  Exposing ports should only be valid port numbers.

from dockerfilelint.

marccampbell avatar marccampbell commented on May 22, 2024

@thomasbiddle Agreed. Will you open a new issue for the ENV PORT; EXPOSE $PORT pattern? I think we should add this in, but we should also do it correctly and ensure that the env var is set and still a valid value (when possible).

from dockerfilelint.

thomasbiddle avatar thomasbiddle commented on May 22, 2024

@marccampbell Referenced in #86.

from dockerfilelint.

nexdrew avatar nexdrew commented on May 22, 2024

Closing this as it should be fixed in version 1.3.0+. Please let us know if you still have problems with the "port/proto" syntax.

(Also note that fromlatest.io isn't currently running the latest version of dockerfilelint, see replicatedhq/fromlatest.io#242.)

from dockerfilelint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.