Beautify the default color scheme about kaizen-openapi-editor

[tedepstein]

In API Studio, we are using the Eclipse Color Theme plugin, with a dark color theme (inkpot) selected. For general use outside of API studio, we probably should not assume a dark background, so we should choose colors that works with a light background.

[ghillairet]

Note that eclipse color theme plugins requires that mappings for specific editors are contributed (see https://github.com/eclipse-color-theme/eclipse-color-theme/wiki/Contributing). The mapping for YEdit is already present in the current version of eclipsecolortheme, that explains why SwagEdit works well with it.

Also the general use of this color theme plugin is that users choose a theme and then all their editors use that particular theme.

The default theme from Eclipse is the one with white background and purple color for keywords (see Java editor for ex). Maybe this one should be use.

[tedepstein]

@ghillairet , can you paste a screenshot with SwagEdit in the default theme?

[ghillairet]

So the default theme for YEdit does not use similar colors as the Eclipse default. Choosing Default theme in eclipse color themes preferences makes editors use their defaults preferences.

Looks like this for YEdit (and SwagEdit)

I was thinking we could provide default preferences that would look like that

[tedepstein]

Yes, I think that second screenshot looks good. Let's go with that color scheme as the default.

[tfesenko]

After having merged the PR, I noticed that what I see is slightly different from the screenshot above:

Note that boolean values ("Constants") are blue in my screenshot, but they are green on Guillaume's.

[tedepstein]

@ghillairet , it also looks to me like the purple/violet color is not the same as in your screenshot. Can we make the default colors match your earlier sceenshot?

[ghillairet]

I took the colors from the default Java editor, in the first screenshot I took colors that look like it.

Here what it looks like on my screen.

[ghillairet]

For info, default colors for SwagEdit are defined here https://github.com/ModelSolv/SwagEdit/blob/master/com.reprezen.swagedit/src/com/reprezen/swagedit/preferences/SwaggerPreferenceInitializer.java#L21

[tedepstein]

I confirmed that the purple color matches Eclipse's default for Java keywords. Boolean constants are blue, also apparently consistent with Java's color scheme.

@tfesenko , I'm satisfied with these colors. If you approve, please close this.