GithubHelp home page GithubHelp logo

Comments (6)

sachinjain024 avatar sachinjain024 commented on May 13, 2024

Thanks @caviyacht for logging the issue. If I understand you correctly, you have a replace rule with multiple pairs in it and the problem is only first pair is getting fired and remaining pairs are not getting fired. For example:

Replace q=1 with q=2
When Url contains example.com

Replace q=2 with q=3 
When Url contains example.com

So when user visits, example.com?q=1, Ideally he should see example.com?q=3 because of two pairs in the same rule. Is that similar to your rule ?

Note

We have lately fixed a bug where multiple rules (redirect, cancel, replace etc) could be fired on same request. Now, with latest change only one rule can modify a request and once a request is modified it is not available to other rules for modification.

from requestly.

caviyacht avatar caviyacht commented on May 13, 2024

@sachinjain024 , thanks for the quick reply. Yes, this is exactly what I am doing, and I can see how that bug fix would cause this to stop working.

I guess how I always took it was that the pairs in a rule would execute together in order, otherwise I do not see a real use in having multiple pairs in a rule.

So if the first pair in a rule matched, then everything else in that rule is ok to execute. Was this the intended behavior? That way the multiple-rule execution prevention logic can still be in place, but a let a single rule do multiple things to a request.

from requestly.

sachinjain024 avatar sachinjain024 commented on May 13, 2024

@caviyacht Yes, I am able to reproduce the issue. Currently, first pair is getting executed only and then rest of the pairs are not getting executed. This is certainly a bug.

Pairs in a single rule allows users to perform multiple actions on a given request. Performing multiple rules on a single request makes things complex for debugging and understanding what is happening exactly.

I will try to fix this by EOD IST.

from requestly.

sachinjain024 avatar sachinjain024 commented on May 13, 2024

@caviyacht We have fixed this issue. Please allow us a couple of days to deploy the extension to chrome store and firefox server. Fix should be available in the next version.

from requestly.

requestly-team avatar requestly-team commented on May 13, 2024

@caviyacht We have fixed this issue and deployed v5.1.3 in chrome store. It should be available in half an hour or so. Thanks for your patience.

from requestly.

sachinjain024 avatar sachinjain024 commented on May 13, 2024

Looks like the issue is fixed so closing this one.

from requestly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.