GithubHelp home page GithubHelp logo

Comments (4)

jrburke avatar jrburke commented on May 26, 2024

This is fixed in this commit. I also opened a ticket on the "main relative to package root" issue.

from requirejs.

kriszyp avatar kriszyp commented on May 26, 2024

This looks good, but I don't think it is quite right. Now I am seeing an issue where the module factory gets executed twice. In my test in https://github.com/kriszyp/has.js/blob/master/tests/requirejs-plugin.html the has.js is loaded once through a module id of "has" and then is later referenced by "./has" (from _plugin.js) which seems to correctly resolve to right URL since it doesn't trigger an additional script load, but it does seem to trigger an additional execution of the has.js factory function.

from requirejs.

jrburke avatar jrburke commented on May 26, 2024

I am actually seeing two requests: one for a module called "has" and one for "has/has". I think the disconnect is because "has" loads "./_plugin", which is inside the package, and it requires "./has", which since a relative module ID gets resolved as "has/has", and that is not tied back to being the "has" top-level package module name.

I was trying to avoid using urls for tracking cached module values, but that would be one way to solve it. Will think about it a bit more.

from requirejs.

jrburke avatar jrburke commented on May 26, 2024

I put in a fix for paths that resolve to the main module in a package config in this commit

from requirejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.