Comments (2)
I'd suggest not making this change, and instead rely upon the "inspect" method to generate a robust, human-readable form that you need. We can add other debugging methods, but the raw macaroon representation underneath base64 is not guaranteed to be human readable. In fact, caveats are 8-bit safe bytestrings, so it's always possible to have a macaroon without human readable plaintext.
Doubling the space used for vid and signature strings is not good for our use case.
BTW, the current form is in use both in our implementation, and in @rogpeppe's implementation. I'm roping him in here to get his opinion on this change, but I would prefer to maintain the current format that is compatible with both of our implementations.
Another way we could go is to standardize the JSON format, finish that code, and then you can use the JSON format for all of your macaroons, as the JSON format will be significantly more verbose and human-readable. Thoughts?
from libmacaroons.
Makes totally sense to me.
To my understanding, using the default serialization is preferred for smaller size.
And using the JSON serialization is suites better in cases where human readability and verboseness counts.
When there will be progress in standardizing the JSON format, I will adopt this for jmacaroons.
For now, I also will maintain the current format for jmacaroons.
Thanks for clarifying this.
from libmacaroons.
Related Issues (20)
- Seemingly contradictory readme HOT 2
- Cant Build from source HOT 1
- macaroon_deserialize_json is not declared in macaroons.h HOT 2
- serialization produces invalid base64 HOT 4
- macaroon_hash2 has unexpected implementation HOT 3
- pyx function signature error HOT 1
- Leftovers in Go Bindings HOT 1
- Building libmacaroons on OS X HOT 3
- how does it work? HOT 7
- Cookies are different from session IDs HOT 4
- No installation documentation + Linux installation problems HOT 6
- syntax error in VERSION script HOT 2
- third party caveats produce invalid JSON when serialized HOT 1
- python bindings: produce better error when format not recognized HOT 1
- first party caveats are not always checked by verifier HOT 4
- version 1 JSON serialization not supported
- Version 0.4.0 roadmap? HOT 2
- Add pip installation instructions to the README
- Potential undersized buffer
- pkg-config is required HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libmacaroons.