GithubHelp home page GithubHelp logo

Comments (2)

rescrv avatar rescrv commented on July 26, 2024

I'd suggest not making this change, and instead rely upon the "inspect" method to generate a robust, human-readable form that you need. We can add other debugging methods, but the raw macaroon representation underneath base64 is not guaranteed to be human readable. In fact, caveats are 8-bit safe bytestrings, so it's always possible to have a macaroon without human readable plaintext.

Doubling the space used for vid and signature strings is not good for our use case.

BTW, the current form is in use both in our implementation, and in @rogpeppe's implementation. I'm roping him in here to get his opinion on this change, but I would prefer to maintain the current format that is compatible with both of our implementations.

Another way we could go is to standardize the JSON format, finish that code, and then you can use the JSON format for all of your macaroons, as the JSON format will be significantly more verbose and human-readable. Thoughts?

from libmacaroons.

nitram509 avatar nitram509 commented on July 26, 2024

Makes totally sense to me.
To my understanding, using the default serialization is preferred for smaller size.
And using the JSON serialization is suites better in cases where human readability and verboseness counts.
When there will be progress in standardizing the JSON format, I will adopt this for jmacaroons.
For now, I also will maintain the current format for jmacaroons.

Thanks for clarifying this.

from libmacaroons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.