GithubHelp home page GithubHelp logo

Comments (6)

jph avatar jph commented on August 28, 2024

Upon further investigation this error appears in #53.

I tested with this version and while it appears to work, there are still style-related issues on the Resque-Web page. Namely the links across the black bar at the top are missing, however I think #65 fixes this.

from resque-web.

mcfiredrill avatar mcfiredrill commented on August 28, 2024

@jph I've merged #53, I'd like to merge #65 but I haven't tested it and I'm not sure if there are any other breaking changes with upgrading to bootstrap 3.

from resque-web.

jph avatar jph commented on August 28, 2024

Right, makes perfect sense. Will keep an eye on it. :)

On 20/08/2014 11:14, Tony Miller wrote:

@jph I've merged #53, I'd like to merge #65 but I haven't tested it and I'm not sure if there are any other breaking changes with upgrading to bootstrap 3.


Reply to this email directly or view it on GitHub:
#67 (comment)

from resque-web.

mcfiredrill avatar mcfiredrill commented on August 28, 2024

If some people test it and confirm nothing else breaks I will gladly merge
it. :)

On Wed, Aug 20, 2014 at 10:46 AM, jph [email protected] wrote:

Right, makes perfect sense. Will keep an eye on it. :)

On 20/08/2014 11:14, Tony Miller wrote:

@jph I've merged #53, I'd like to merge #65 but I haven't tested it and
I'm not sure if there are any other breaking changes with upgrading to
bootstrap 3.


Reply to this email directly or view it on GitHub:
#67 (comment)


Reply to this email directly or view it on GitHub
#67 (comment).

-Tony Miller
github.com/mcfiredrill
@freedrull
freedrool.us

from resque-web.

jph avatar jph commented on August 28, 2024

First off if there's anything I've missed let me know.

I've done some testing (within Rails) and the styles look much better to me. It looks like the red background highlight on the buttons across the top menu are not working however this is still better than how it is currently.

I also cloned the PR and run the test suite without any errors:

[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.
Run options: --seed 47860

# Running tests:

.................................

Finished tests in 0.526560s, 62.6709 tests/s, 110.1489 assertions/s.

33 tests, 58 assertions, 0 failures, 0 errors, 0 skips
[Coveralls] Outside the Travis environment, not sending data.

Current version Gemfile (resque-web 0.0.6):

gem 'resque-web', require: 'resque_web'

Current version screenshot:
screen shot 2014-08-20 at 13 09 31

#65 Gemfile:

gem 'resque-web', require: 'resque_web', git: "git://github.com/mobirobo/resque-web.git"

#65 screenshot
screen shot 2014-08-20 at 13 03 22

from resque-web.

darinkrauss avatar darinkrauss commented on August 28, 2024

FYI: PR #65 replaced by PR #68.

from resque-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.