Comments (6)
Upon further investigation this error appears in #53.
I tested with this version and while it appears to work, there are still style-related issues on the Resque-Web page. Namely the links across the black bar at the top are missing, however I think #65 fixes this.
from resque-web.
@jph I've merged #53, I'd like to merge #65 but I haven't tested it and I'm not sure if there are any other breaking changes with upgrading to bootstrap 3.
from resque-web.
Right, makes perfect sense. Will keep an eye on it. :)
On 20/08/2014 11:14, Tony Miller wrote:
@jph I've merged #53, I'd like to merge #65 but I haven't tested it and I'm not sure if there are any other breaking changes with upgrading to bootstrap 3.
Reply to this email directly or view it on GitHub:
#67 (comment)
from resque-web.
If some people test it and confirm nothing else breaks I will gladly merge
it. :)
On Wed, Aug 20, 2014 at 10:46 AM, jph [email protected] wrote:
Right, makes perfect sense. Will keep an eye on it. :)
On 20/08/2014 11:14, Tony Miller wrote:
@jph I've merged #53, I'd like to merge #65 but I haven't tested it and
I'm not sure if there are any other breaking changes with upgrading to
bootstrap 3.
Reply to this email directly or view it on GitHub:
#67 (comment)—
Reply to this email directly or view it on GitHub
#67 (comment).
-Tony Miller
github.com/mcfiredrill
@freedrull
freedrool.us
from resque-web.
First off if there's anything I've missed let me know.
I've done some testing (within Rails) and the styles look much better to me. It looks like the red background highlight on the buttons across the top menu are not working however this is still better than how it is currently.
I also cloned the PR and run the test suite without any errors:
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.
Run options: --seed 47860
# Running tests:
.................................
Finished tests in 0.526560s, 62.6709 tests/s, 110.1489 assertions/s.
33 tests, 58 assertions, 0 failures, 0 errors, 0 skips
[Coveralls] Outside the Travis environment, not sending data.
Current version Gemfile (resque-web 0.0.6):
gem 'resque-web', require: 'resque_web'
#65 Gemfile:
gem 'resque-web', require: 'resque_web', git: "git://github.com/mobirobo/resque-web.git"
#65 screenshot
from resque-web.
FYI: PR #65 replaced by PR #68.
from resque-web.
Related Issues (20)
- Error resque_web/failures
- before_action doesn't work in rails 3 HOT 1
- ERR invalid password when port is incorrect
- Error undefined method 'root_path' for ActionDispatch::Routing::RoutesProxy HOT 1
- undefined method `connect' for Redis:Class #19 HOT 1
- replace sass with sassc HOT 2
- Issues with LESS in old bootstrap gem
- Failed jobs can't be cleared HOT 5
- Relative url path is ignored HOT 2
- A tutorial for people who know nothing about Ruby
- Rails 6.0 compatibility?
- Workers started value does not load for Firefox or Safari
- Resque-Web Alternative HOT 8
- Any way to allow for better template integration?
- Rails 6.0 DEPRECATION WARNING: Initialization autoloaded the constant BadgeLabelHelper. HOT 1
- Cancel job doesn't work if queued in a different queue
- Redis::CommandError - CROSSSLOT Keys in request don't hash to the same slot HOT 3
- NameError: uninitialized constant Resque::Version HOT 13
- File to import not found or unreadable: font-awesome-sprockets HOT 2
- Getting error "Invalid route name, already in use: 'root'" when trying to add tabs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from resque-web.