Problem with words like "night’s" causing keyphrases to be malformed due to ’ character about retext-keywords

[fmacpro]

the issue appears to occur during the mapping done by nlcstToString

[wooorm]

nlcst-to-string does accept a second argument, the separator, which is used to join stuff together.
This kind of looks like it could be accidentally passed by using someWords.map(nlcstStoString), but I don’t think that happens here or in retext-pos? 🤔

[fmacpro]

thanks for your tip @wooorm . I've found a workaround by using the lodash module _.map function - i'm not exactly sure why this works and the current method doesn't though 🙃.

please see the working example below:

var retext = require('retext');
var keywords = require('retext-keywords');
var nlcstToString = require('nlcst-to-string');
var _ = require('lodash');

var text = "Last night’s concert was the third in a series organised by the Lizz Hobbs Group, who have now produced concerts at Slessor Gardens two years in a row.";

retext()
  .use(keywords)
  .process(text, function (err, file) {
    if (err) throw err;

    console.log('Keywords:');
    file.data.keywords.forEach(function (keyword) {
      console.log(nlcstToString(keyword.matches[0].node));
    });

    console.log();
    console.log('Key-phrases:');
    file.data.keyphrases.forEach(function (phrase) {
      
      //console.log(phrase.matches[0].nodes.map(nlcstToString).join(''));

      var nodes = phrase.matches[0].nodes;
      var tree = _.map(nodes);
      console.log(nlcstToString(tree, ""));
    });
  }
);

which gives as expected:

Keywords:
concert
Last
night’s
third
series
Lizz
Hobbs
Group
Slessor
Gardens
two
years
row

Key-phrases:
Last night’s concert
Slessor Gardens two years
Lizz Hobbs Group
concerts

[wooorm]

Ah, I fixed the example in the readme. Thanks!