GithubHelp home page GithubHelp logo

Comments (17)

geertjanw avatar geertjanw commented on July 30, 2024 7

OK, looks like it will still take quite some time, the 4th donation scheduled for around September, but am trying to see if we can squeeze this in too.

from nb-darcula.

Chris2011 avatar Chris2011 commented on July 30, 2024 6

I really like darcula and I use it every day, but it still has some UI downsides. It is a mix of some old NetBeans stuff like gradients and flat and clean design. IMHO we should focus on flatlaf: https://github.com/JFormDesigner/FlatLaf it still has HiDPI support, looks flat (no shadows, no gradients, this is what flat means) and it comes from the JFormDesigner developers, so I guess there are more people involved in that, than here. The license is already Apache 2.0.

Here you can see a very first quick experiment by adding it into my plugin:

image

It looks very nice and clean, but still has some problems. But I think this is the way to go instead of using this code here.

Here is the comparison between the FlatDarculaLaf (left) and the nb-darcula (right):

image

It has these look and feels:

  • Flat Light
    (class com.formdev.flatlaf.FlatLightLaf)
  • Flat Dark
    (class com.formdev.flatlaf.FlatDarkLaf)
  • Flat IntelliJ
    (class com.formdev.flatlaf.FlatIntelliJLaf)
    looks like IntelliJ theme from IntelliJ IDEA 2019.2+
  • Flat Darcula
    (class com.formdev.flatlaf.FlatDarculaLaf)
    looks like Darcula theme from IntelliJ IDEA 2019.2+

Here is the site of the project: https://www.formdev.com/flatlaf/

from nb-darcula.

lkishalmi avatar lkishalmi commented on July 30, 2024 1

Well, he says that he would like to donate but has a busy time in his life right now.
I've prepared the integration into NB build/module system as of https://github.com/lkishalmi/incubator-netbeans/tree/nb-darcula he cloned that. All he needs to do is become an ASF Committer then file a PR.

from nb-darcula.

lkishalmi avatar lkishalmi commented on July 30, 2024 1

Well @Revivius Is quite busy these days. Actually that's what he is telling. Fortunately/unfortunately some of his code depends on the NB Dark LaF modules, which are not donated yet (they missed the first donation train). As that issue has been resolved it is legally not possible to release the code under Apache license.
We might ask @geertjanw that is it possible to change the schedule on that donation.

from nb-darcula.

Chris2011 avatar Chris2011 commented on July 30, 2024

That would be awesome :)

from nb-darcula.

gilbertoca avatar gilbertoca commented on July 30, 2024

@lkishalmi @geertjanw another plugin very popular and with problems as well is the "Display readme files in project view" [1][2]

[1]https://github.com/markiewb/readmeinprojectview
[2]http://plugins.netbeans.org/plugin/50171/

from nb-darcula.

Chris2011 avatar Chris2011 commented on July 30, 2024

@gilbertoca so please make a ticket there. Your request has nothing todo with this plugin.

from nb-darcula.

yusufbaspinar avatar yusufbaspinar commented on July 30, 2024

Dear Revivius,
Thank you for your contribution to NetBeans comunity.

from nb-darcula.

Chris2011 avatar Chris2011 commented on July 30, 2024

@lkishalmi Is it correct, that you had a talk with @Revivius in private about that? Anything new here?

from nb-darcula.

Chris2011 avatar Chris2011 commented on July 30, 2024

Ahh ok, thx for the info :)

from nb-darcula.

zimmi avatar zimmi commented on July 30, 2024

Hi, I hope you are doing well!
Are there any news regarding the donation?
Darcula is my favorite theme and it would be great if it could be made an "official" part of NetBeans.
I'd also like to thank @Revivius for developing it. It must have saved a significant amount of cumulative eyesight over the years.

from nb-darcula.

GeertjanWielenga avatar GeertjanWielenga commented on July 30, 2024

Sorry, I think this is the first I hear of this. Which undonated code exactly?

from nb-darcula.

lkishalmi avatar lkishalmi commented on July 30, 2024

@GeertjanWielenga Yes this is the first time I spoke of that, I was keeping that "secret" in the back of my mind.
Things like this: https://github.com/lkishalmi/netbeans/blob/nb-darcula/platform/c.revivius.nb.darcula/src/com/revivius/nb/darcula/DarkIconFilter.java
Probably there is one or two more.
And the undonated code would be the dark LaF-s (dark Metal and Nimbus) which is scheduled for the V. donation according to: https://cwiki.apache.org/confluence/display/NETBEANS/Apache+Transition

from nb-darcula.

geertjanw avatar geertjanw commented on July 30, 2024

Where in this repo are the files found, which specific files in this repo are we talking about: https://hg.netbeans.org/releases/file

from nb-darcula.

geertjanw avatar geertjanw commented on July 30, 2024

Ah, OK, I see, this: https://hg.netbeans.org/core-main/file/tip/o.n.swing.laf.dark

from nb-darcula.

lkishalmi avatar lkishalmi commented on July 30, 2024

Yes, that one!

from nb-darcula.

lkishalmi avatar lkishalmi commented on July 30, 2024

FlatLaf won. It will be released in NetBeans 11.3

from nb-darcula.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.