Update feature does not work. about sam

[wazerstar]

@rex706 if you compare the 2 videos, now you can actually see some github url in the updater txt which you could not before.

but still crashes

https://streamable.com/m494mf

I bet it's some missing runtime files exe/dll's or something that you have installed on the PC that we "don't" have, so yours working and assuming it works for all then :)

[wazerstar]

@rex706

New video

https://streamable.com/abnvs2

[wazerstar]

@rex706 I just tested on a brand new windows 10 installation, and a server running Windows 11, same thing happens, it crashes, and never gets the file updated.

[wazerstar]

Made some changes to the Updater. I think the problem is that SAM is not closing in time before the updater attempts to delete the existing file. Please try it again and let me know @wazerstar

Yes works now, but does not delete updater.exe tho, finally!

This has been an issue ever since update was introduced and we talked about this on discord ever since early start of the program :)

I don't know how it never would fail for you..

Congrats with this and thanks :)

[MichaelDavidGK]

@rex706 still the case in 1.5.2.0

[rex706]

@MichaelDavidGK I don't have an issue. what happens?

[MichaelDavidGK]

@MichaelDavidGK I don't have an issue. what happens?

it gives you a prompt to download, it downloads it and it doesn't replace old file :(

should also start program again after update

the guy above had it recorded, it's basically a loop that it always asks you to update since it never replaced the file and you are still on old version

[rex706]

@MichaelDavidGK does it download the new SAM executable to the same directory as the old one?

Edit: also, does the updater executable appear in the SAM directory when the updater is open?

[wazerstar]

@rex706 This is what happens, nothing, just goes loop when you restart client

https://streamable.com/qms5h1

Updater

https://i.imgur.com/7pCKwV5.png

[rex706]

Alright I pushed a minor update to the updater. Try again and let me know if it helps. You will know you have the new updater by the version in the title bar.

[wazerstar]

Alright I pushed a minor update to the updater. Try again and let me know if it helps. You will know you have the new updater by the version in the title bar.

Cannot update anything when using latest client?

Tested on older version and still does the same.

[MichaelDavidGK]

Alright I pushed a minor update to the updater. Try again and let me know if it helps. You will know you have the new updater by the version in the title bar.

1.1.0.8 for updater, still doesn't work, maybe it is not downloading, I assumed it was as my internet is over 1gbps

only updater.exe shows up in folder

it's exactly as on the video @wazerstar uploaded

[rex706]

It looks like it's crashing before it can actually download anything in the recent clip @wazerstar posted. There are try/catch clauses everywhere in the updater, which makes it weird that there isn't any error popup at any point. Maybe there is an issue with reading the manifest URL from the launch arguments.

[rex706]

@wazerstar please test it out again when you get the chance, thanks!

[MichaelDavidGK]

@rex706 any update on this?

[rex706]

@MichaelDavidGK I've tried a couple different things, but it is tricky to troubleshoot since it is working as expected for me. The updater is fed a URL to the update manifest file, which is this: https://raw.githubusercontent.com/rex706/SAM/master/latest.txt

For some reason the updater appears to crash either before or during the read operation for the manifest file. I don't think it actually starts the download process before it crashes, but I could be wrong since it's hard to tell from the videos exactly when it fails.

[wazerstar]

@MichaelDavidGK I've tried a couple different things, but it is tricky to troubleshoot since it is working as expected for me. The updater is fed a URL to the update manifest file, which is this: https://raw.githubusercontent.com/rex706/SAM/master/latest.txt

For some reason the updater appears to crash either before or during the read operation for the manifest file. I don't think it actually starts the download process before it crashes, but I could be wrong since it's hard to tell from the videos exactly when it fails.

add some debug so we can give log?

[rex706]

I will test later today with a fresh windows install before pushing another update for SAM.

[rex706]

Made some changes to the Updater. I think the problem is that SAM is not closing in time before the updater attempts to delete the existing file. Please try it again and let me know @wazerstar