Explicit dependency on -ldl is missing from libefivar.so about efivar

[superm1]

Jared suspects that this is caused by https://wiki.ubuntu.com/NattyNarwhal/ToolchainTransition.

I've found that the following patch fixes the problem for me:

From 488eb3f649aa33bbe5c641314398972efa2f649d Mon Sep 17 00:00:00 2001
From: Mario Limonciello <[email protected]>
Date: Tue, 2 Jun 2015 10:11:18 -0500
Subject: [PATCH] Make libdl an explicit dependency for libefivar.so.0

pesign is still failing to build, this fixes it.

Signed-off-by: Mario Limonciello <[email protected]>
---
 src/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Makefile b/src/Makefile
index f8ac6bd..a238189 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -34,7 +34,7 @@ EFIBOOT_DEPS = \

 libefivar.a :: $(EFIVAR_OBJECTS)

-libefivar.so.$(SONAME_VERSION) :: $(EFIVAR_OBJECTS)
+libefivar.so.$(SONAME_VERSION) :: $(EFIVAR_OBJECTS) $(foreach lib,$(EFIVAR_LIBS),-l$(lib))

 libefiboot.a :: $(EFIBOOT_OBJECTS)

--
1.9.1

This causes ldd to have an explicit dependency and allows pesign to build properly.

$ ldd src/libefivar.so
linux-vdso.so.1 =>  (0x00007ffda4fcb000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f850bcdc000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f850b917000)
/lib64/ld-linux-x86-64.so.2 (0x00007f850c127000)

[floppym]

That patch seems somewhat incorrect. It seems to cause /usr/lib/libdl.so to be passed to the linker, which will cause the build to fail on a multilib (32/64-bit) system, where /usr/lib and /usr/lib64 contain different ABIs.

x86_64-pc-linux-gnu-gcc -O2 -pipe -march=native -frecord-gcc-switches -Wall -Wsign-compare -std=gnu11 -fshort-wchar -fPIC -fvisibility=hidden -D_GNU_SOURCE -I/tmp/portage/sys-libs/efivar-0.20/work/efivar-0.20/src/include/efivar/   -Wl,-soname,libefivar.so.0 -O2 -pipe -march=native -frecord-gcc-switches -Wall -Wsign-compare -std=gnu11 -fshort-wchar -fPIC -fvisibility=hidden -D_GNU_SOURCE -I/tmp/portage/sys-libs/efivar-0.20/work/efivar-0.20/src/include/efivar/    -Wl,-O1 -Wl,--as-needed   -shared dp.o dp-acpi.o dp-hw.o dp-media.o dp-message.o efivarfs.o export.o guid.o guidlist.o guid-symbols.o lib.o vars.o /usr/lib/libdl.so -o libefivar.so.0
/usr/lib/libdl.so: error adding symbols: File in wrong format
collect2: error: ld returned 1 exit status