GithubHelp home page GithubHelp logo

Comments (3)

jtudelag avatar jtudelag commented on July 19, 2024

Hey @tylerauerbeck I have struggled to make the LDAP integration for Gitlab, I have realized there is kind a chicken egg problem with the bind password lookup and the secret. I think we might want to add a secret template in the chart, or just get rid od the secret Lookup and just pass the password directly as a variable in the Values file.

from enablement-framework.

tylerauerbeck avatar tylerauerbeck commented on July 19, 2024

@jtudelag The only issue I've seen is when I forget to update this secret name in the values file:
https://github.com/rht-labs/enablement-framework/blob/main/tooling/charts/do500/values.yaml#L47

In that case, since the dummy secret name I have there doesn't exist it returns a blank file (and then the gitlab configure has an empty bind password).

There shouldn't be too much of a chicken and the egg issue here becuase the bind password and secret are already created as part of the cluster deploy (so far before the gitlab or any of the other do500 components are ever stood up). Happy to take a look at this with you at some point though if there's just something else I haven't seen up to this point.

from enablement-framework.

jtudelag avatar jtudelag commented on July 19, 2024

@jtudelag The only issue I've seen is when I forget to update this secret name in the values file:
https://github.com/rht-labs/enablement-framework/blob/main/tooling/charts/do500/values.yaml#L47

In that case, since the dummy secret name I have there doesn't exist it returns a blank file (and then the gitlab configure has an empty bind password).

There shouldn't be too much of a chicken and the egg issue here becuase the bind password and secret are already created as part of the cluster deploy (so far before the gitlab or any of the other do500 components are ever stood up). Happy to take a look at this with you at some point though if there's just something else I haven't seen up to this point.

Prob I did not explain myself correctly, my point is, assuming Gitlab Pod can only reference secrets within it's own namespace, and that NS is usually created by the DO500 chart, a secret with the bindPassword data should be part of the Gitlab manifests. I don't see how you can reference an already created secret in the cluster.

Am I talking non-sense??? ๐Ÿ™„

from enablement-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.