GithubHelp home page GithubHelp logo

Comments (6)

dieghernan avatar dieghernan commented on June 2, 2024

I didn’t mention, Travis for R-devel is failing, but also prior to the change, it seems that the devel guys had done something bad... see the build of my forked master, still not updated: https://travis-ci.com/dieghernan/cartography/builds/150727411

from cartography.

rCarto avatar rCarto commented on June 2, 2024

Yeah I saw that. The faulty warning is Warning: multiple methods tables found for ‘plot’. To be honnest I don't understand it :-)

from cartography.

dieghernan avatar dieghernan commented on June 2, 2024

May be related with this change:
https://developer.r-project.org/blosxom.cgi/R-devel/NEWS/2020/03/07#n2020-03-07

Sat, 07 Mar 2020

CHANGES IN R-devel USER-VISIBLE CHANGES

The ‘plot()’ generic function is now in package ‘base’ rather than package ‘graphics’, as it is reasonable to have methods that do not use the ‘graphics’ package. The generic is currently re-exported from the ‘graphics’ namespace to allow packages importing it from there to continue working, but this may change in future versions of R.

from cartography.

rCarto avatar rCarto commented on June 2, 2024

Well spotted. I only had to remove plot() from graphics imports around here and get rid of package cache in .travis.yml (here).
The package is now only tested on devel as devel and release are now incompatible and devel is the target for pkg release...

from cartography.

dieghernan avatar dieghernan commented on June 2, 2024

I have made a couple of tests and I think you can still tests on release and oldrel with a couple of changes:

  • Slight modification of the Travis Build Matrix, now caching only on release and oldrel
  • Import the whole graphics NAMESPACE. On oldrel and release that would include plot without explicit mention, so it wouldn't crash on devel.

master...dieghernan:travisrelease

See link to build:

https://travis-ci.com/github/dieghernan/cartography/builds/153161959

Let me know if you want me to prepare a PR.

from cartography.

rCarto avatar rCarto commented on June 2, 2024

Nice, a PR would be welcomed.

from cartography.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.