GithubHelp home page GithubHelp logo

Comments (2)

Rich-Harris avatar Rich-Harris commented on August 25, 2024

It'd be easy enough to implement, definitely. Only thing is that it would mean that we couldn't then use the arguments to done for anything else, if we came up with a better use for them, so we'd need to be sure that it was worthwhile, especially since we've got .bind. Personally I've only ever used a closure for done...

var from = someNode;
var to = someOtherNode;

ramjet.transform( from, to, {
  done: function () {
    // we can already access `from` and `to` here...
    // no need to have them as arguments
  }
});

...so there's not much to be gained in that scenario. But I'd be interested to see examples where passing the arguments in would make life easier?

from ramjet.

bradparks avatar bradparks commented on August 25, 2024

yeah, i think you're totally right... especially given the fact that maybe something else could be passed in laster on that might be more relevant... thanks again!

from ramjet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.