GithubHelp home page GithubHelp logo

[Bug]: about filament-email HOT 7 CLOSED

torriv83 avatar torriv83 commented on August 26, 2024
[Bug]:

from filament-email.

Comments (7)

RickDBCN avatar RickDBCN commented on August 26, 2024

Hi Torri,

I need some more time to reproduce this, as I'm unable to reproduce.
I'll get back to you asap.

from filament-email.

quasiperfect avatar quasiperfect commented on August 26, 2024

i think i can fix this in the weekend or if is urgent anyone can pr

here
https://github.com/RickDBCN/filament-email/blob/main/src/Filament/Resources/EmailResource.php#L159
we need to add something like
->action(fn (Collection $records) => $records->each->delete()),
see here https://filamentphp.com/docs/3.x/tables/actions#bulk-actions

from filament-email.

RickDBCN avatar RickDBCN commented on August 26, 2024

Hmm, I'm confident that the BulkDeleteAction should automatically include the delete for each record. Will need to check.

from filament-email.

quasiperfect avatar quasiperfect commented on August 26, 2024

@RickDBCN if you remove ->action(function () { Notification::make() ->title('Emails succesfully deleted') ->success() ->send(); }), i think it will work ok. the bulk action already sends a notification

from filament-email.

torriv83 avatar torriv83 commented on August 26, 2024

I can confirm that removing the ->action resolves this bug for me. I have never done a PR before, so i'm not sure the step to make a PR.

from filament-email.

torriv83 avatar torriv83 commented on August 26, 2024

I tried making a PR. hopefully it works :)

from filament-email.

RickDBCN avatar RickDBCN commented on August 26, 2024

I tried making a PR. hopefully it works :)

It did, thanks!

from filament-email.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.