Comments (5)
Comment by hendrikebbers
Wednesday Feb 17, 2016 at 23:47 GMT
@aalmiray Is this issue still relevant?
I think that we could use @Inject at the controller constructors now (never tried it). What would not work is using the model (@dolphinmodel) as a injectable constructor param. This is more or less related to CDI (would work in Spring).
from rico.
Comment by aalmiray
Thursday Feb 18, 2016 at 08:19 GMT
Very much relevant. I'd like to see an API that's friendly to DI. This doesn't mean core DP classes must be annotated with @Inject for this to work, however it wouldn't hurt, given that classes can still be instantiated in a non-DI environment even if their constructor are annotated with @Inject.
from rico.
Comment by hendrikebbers
Friday Mar 11, 2016 at 10:49 GMT
@aalmiray I think we should close this issue and maybe open more specific ones. Since this issue was opened we defined several factories and more will comme (see Pull Requests for server refactoring). Based on this I think that we should not have a general "provide factories" issue anymore. I think it would be better to create a specific issue if you are missing a factory.
About the DI support: For this we can create a separate issue. Here my idea is to private an implementation of DP server that simply runs in a tomcat. Here the controllers will be created "by hand" or with the help of a DI framework like Guice. I think the current code is well prepared for such a third implementation next to Spring and JavaEE.
from rico.
Comment by aalmiray
Friday Mar 11, 2016 at 10:53 GMT
Well, this issue already discusses the usage of @Inject
. It mentions a factory to exemplify why the use of DI would be a good idea. I don't see the need to close this issue and open another one.
from rico.
Comment by hendrikebbers
Friday Mar 11, 2016 at 10:56 GMT
ok, then just link this one with #42 that contains the need of factories. This issue will then define the need for low level DI. Ok
from rico.
Related Issues (20)
- clarify FIXME comment in TestClientConnectorImpl
- Rico version is not shown correctly in banner HOT 1
- Byte[] support in model by adding ConverterFactory implementation
- Adding . editorconfig file HOT 2
- External repository links for client library implementations in README are pointing to a wrong URL HOT 2
- Fix release build and version numbers
- Add git commit hash to MANIFEST.MF file. HOT 3
- Rico-Angular: Using multiple controllers duplicates model entries HOT 1
- Rico-Angular: Instanciating multiple controllers "at the same time" mixes up the model references HOT 4
- Rico-JS, Rico-Angular: Move functionality to Rico-JS.
- Security: NPE if user has no roles
- Better error handling in ClientSessionLifecycleHandlerImpl
- Double.NEGATIVE_INFINITY won't be transferred correctly by remoting
- Check old branches
- Check old Remoting branches
- apply new package structure to test packages
- SpringJUnitControllerTest is not using Junit 5 HOT 3
- JavaDoc is missing internal links
- Provide Hash-function for Download-Input Stream
- JavaDoc: @Param for generics produces warning HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rico.