Comments (9)
Let me know if this does the trick!
I also added you as a co-author. Thanks for contributing!
from color2k.
Filed #352.
from color2k.
Hello there!
Thank you for filing an issue and opening a PR so quickly. I appreciate it and I'll definitely try to resolve this within the next few hours.
v1.2.1 breaks on node 6 with a syntax error, which is a breaking change in a minor version
I apologize for this, that was not the intention whatsoever. Version 1.2 was the version I opted to have this lib be bundled by microbundle
instead of my own rollup config. The irony of this is that the switch caused more noise than convenience.
Please fix this ASAP, so react-dates can continue depending on this package. I'll be happy to make a PR.
There's nothing wrong with your PR as-is, however, I'm currently hesitant on taking any sort of dependencies just by the principles of this lib. Let me spend a few minutes trying to come up with alternatives that don't add dependencies and I'll post here when that's done.
Out of curiosity, why does react-dates need to support Node 6 in the first place? Is there an upstream issue? Most ecosystems I've seen only support Node 10+. (e.g. create-react-app
and next
)
from color2k.
π This issue has been resolved in version 1.2.3 π
The release is available on:
Your semantic-release bot π¦π
from color2k.
@ljharb, I just opened #354 with the topic of adding Node 6 support tests in CI.
If you're familiar with how to do that kind of testing, some guidance (or even a PR) would be greatly appreciated and would ensure any changes that break Node 6 compatibility would become blockers.
from color2k.
react-dates supports much older nodes than 6; itβs a browser lib so it needs to support IE 11, for example.
Itβs fine if you donβt want a dependency, altho more deps are better :-)
Sure, i can look into the tests.
from color2k.
Re-opening since you found this: #353 (comment)
from color2k.
Filed #355 for the fix; #356 for the tests.
from color2k.
π This issue has been resolved in version 1.2.4 π
The release is available on:
Your semantic-release bot π¦π
from color2k.
Related Issues (20)
- Try switching to the `exports` entry point instead of `modules` HOT 1
- Action Required: Fix Renovate Configuration
- Package maintenance: semantic-release and microbundle HOT 1
- The main field in the package.json of `[email protected]` points to non-existent TypeScript file HOT 4
- Node 6 Compatibility Suite / Migrate to `tape` HOT 1
- Bundled outputs HOT 1
- IsDark and isLight support? I can not find HOT 1
- Dependency Dashboard
- `mix` returns `NaN` values at extremes with fully transparent colors HOT 1
- node 4 compatibility HOT 1
- Color conversion problem HOT 1
- [Feature] Invert color HOT 1
- [Feature] add support for hex8 HOT 2
- Support space separated rgb values HOT 3
- Using `toHex` with `hsla` where `a = 0` leads to a result with alpha=1 HOT 3
- Does not work with next.js SSR HOT 1
- parseToRgba can't handle percentage alpha values
- Breaks in the latest webkit version HOT 3
- How to verify if a string is a valid color value?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from color2k.