GithubHelp home page GithubHelp logo

Comments (10)

merlinnot avatar merlinnot commented on September 1, 2024

Hi! In this reproduction we were using a gRPC back end and an Envoy proxy deployed as two separate Cloud Run services. This setup works thanks to a host rewrite in the proxy (host is changed from the proxy URL to the back end URL).

from grpc-web-cloud-run-issue.

wlhee avatar wlhee commented on September 1, 2024

Yeah. I understand how the two Cloud Run services are chained together.

My question is more about in the actual production setup, is the envoy proxy deployed as a separate service that dispatches to different backend services, or it's deployed as a side car runs along side with the gRPC service?

It sounds like to me the envoy is a separate service?

from grpc-web-cloud-run-issue.

merlinnot avatar merlinnot commented on September 1, 2024

Yes, Envoy is a separate service. We did consider running them inside of the same container (as Cloud Run doesn't support sidecars per se), but there are a lot of things that need to be taken care of for such a setup to actually work and we use Envoy solely for gRPC-web transcoding - in reality a large portion of the traffic (from clients that support gRPC natively) would travel through a proxy unnecessarily.

from grpc-web-cloud-run-issue.

wlhee avatar wlhee commented on September 1, 2024

Gotcha. I will try something to see if we can workaround the content-length: 0 issue for empty response.

from grpc-web-cloud-run-issue.

wlhee avatar wlhee commented on September 1, 2024

I updated the envoy.yaml to remove the content-length header. It looks like once the C-L is removed, the js client starts working as expected. See the example PR: c734a5e

from grpc-web-cloud-run-issue.

wlhee avatar wlhee commented on September 1, 2024

Also filed an issue to grpc-web: grpc/grpc-web#1101

from grpc-web-cloud-run-issue.

merlinnot avatar merlinnot commented on September 1, 2024

Thanks! Do you think we should open an issue against Envoy as well?

from grpc-web-cloud-run-issue.

wlhee avatar wlhee commented on September 1, 2024

I am not very sure if this is a really bug in envoy, because a regular gRPC client works with C-L: 0 in the resposne.

from grpc-web-cloud-run-issue.

merlinnot avatar merlinnot commented on September 1, 2024

I see. I don't have access to an internal issue mentioned here: grpc/grpc-web#1101 (comment). I'll follow that issue for now. Again, many thanks for looking into this.

from grpc-web-cloud-run-issue.

wlhee avatar wlhee commented on September 1, 2024

No problem!

The internal issue is the same one your team filed.

from grpc-web-cloud-run-issue.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.