GithubHelp home page GithubHelp logo

Comments (4)

z0rc avatar z0rc commented on June 27, 2024

While we're at it I think check shouldn't succeed on internal failure.

from merge-me-action.

mad-it avatar mad-it commented on June 27, 2024

Sorry for taking a bit longer to respond. This will require a bit more of an internal discussions.

There are quite a few cases where we want the errors to be swallowed and not retried. Here are a few examples for our own usages:
##[error]GraphqlError: 5 of 5 required status checks have not succeeded: . - This is an example of when a build is still in progress.
##[error]GraphqlError: 4 of 4 required status checks are expected. - An alternative scenario where a build is still in progress.

So we need to discuss whether we will retry for the specific case you mentioned or come up with a more general solution.

While we're at it I think check shouldn't succeed on internal failure.

I do agree with this, however GitHub actions still does not support restarting individual jobs, so failing the automated check would require you to restart the entire build. So that will be a somewhat nasty side effect. I will take this up as well as the intention of this action is to merge the PR. If that fails it should indeed indicate as much.

from merge-me-action.

mad-it avatar mad-it commented on June 27, 2024

While we're at it I think check shouldn't succeed on internal failure.

This part has been resolved by #469

The rest is pending some discussions :)

from merge-me-action.

ricardoatsouza avatar ricardoatsouza commented on June 27, 2024

Hello @z0rc. Retry on failure for this error was added in this PR: #480. Hope this solves the problem you were having. :)

from merge-me-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.