Comments (4)
While we're at it I think check shouldn't succeed on internal failure.
from merge-me-action.
Sorry for taking a bit longer to respond. This will require a bit more of an internal discussions.
There are quite a few cases where we want the errors to be swallowed and not retried. Here are a few examples for our own usages:
##[error]GraphqlError: 5 of 5 required status checks have not succeeded: .
- This is an example of when a build is still in progress.
##[error]GraphqlError: 4 of 4 required status checks are expected.
- An alternative scenario where a build is still in progress.
So we need to discuss whether we will retry for the specific case you mentioned or come up with a more general solution.
While we're at it I think check shouldn't succeed on internal failure.
I do agree with this, however GitHub actions still does not support restarting individual jobs, so failing the automated check would require you to restart the entire build. So that will be a somewhat nasty side effect. I will take this up as well as the intention of this action is to merge
the PR. If that fails it should indeed indicate as much.
from merge-me-action.
While we're at it I think check shouldn't succeed on internal failure.
This part has been resolved by #469
The rest is pending some discussions :)
from merge-me-action.
Hello @z0rc. Retry on failure for this error was added in this PR: #480. Hope this solves the problem you were having. :)
from merge-me-action.
Related Issues (20)
- Releases once per-day HOT 7
- Action is failing with error if `ENABLE_GITHUB_API_PREVIEW` is disabled HOT 2
- GitHub Action with this Action Starting to Fail 7/21/2021 HOT 2
- Error on all action run HOT 4
- SyntaxError: Unexpected token '?' when action is executed HOT 2
- Pull request not merged HOT 3
- ENABLE_GITHUB_API_PREVIEW only checks against `requiresStrictStatusChecks` and not `requiresStatusChecks`
- PR gets merged before all workflows were successful HOT 4
- Cannot make this action work.
- Resource not accessible by integration, GraphqlError: Resource not accessible by integration HOT 12
- Action prints an error upon merging, but merges successfully HOT 1
- GO get
- T
- **How would you describe the issue?**
- Jial HOT 1
- mergeableState doesn't actually reflect PR status failures HOT 2
- False negative runs against dependabot PRs HOT 4
- How to disable auto merge for dependabot security updates?
- Auto-merging failed producing error related to pullRequest being null HOT 2
- Not recognizing GitHub-native dependabot HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from merge-me-action.