GithubHelp home page GithubHelp logo

Comments (5)

dpwiz avatar dpwiz commented on May 23, 2024

Patch for a missing test:

diff --git a/test/specs/server.specs.js b/test/specs/server.specs.js
index 6a7c77e..3ab29a5 100644
--- a/test/specs/server.specs.js
+++ b/test/specs/server.specs.js
@@ -34,7 +34,12 @@ describe('Server-side specs', function() {
     it('can create sub route context', function() {
       expect(route.create).to.not.throwException()
     })
-    
+
+    it('can terminate sub route context', function() {
+      var subRoute = route.create()
+      expect(subRoute.stop).to.not.throwException()
+    })
+
     it('can define route handlers', function() {
       expect(route).withArgs(function(){}).to.not.throwException()
       expect(route).withArgs('/fruit', function(){}).to.not.throwException()

from route.

chmanie avatar chmanie commented on May 23, 2024

Is there a workaround? This is a very important feature!

from route.

dpwiz avatar dpwiz commented on May 23, 2024

I've used riot.route.stop.bind(subRoute) to some success.

from route.

chmanie avatar chmanie commented on May 23, 2024

I've used riot.route.stop.bind(subRoute) to some success.

👍

Preparing a PR.

from route.

dpwiz avatar dpwiz commented on May 23, 2024

I'm conceding now that subrouting is FUBAR 😩

Perhaps apps should stick to central routing and trigger custom signals to achieve multi-dispatch behaviour.

from route.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.