GithubHelp home page GithubHelp logo

Comments (6)

ripose-jp avatar ripose-jp commented on June 22, 2024 1

I can reproduce the behavior you're getting with SimpleHistory. I'll see if there's some way I can fix it and get back to you. Ideally, I'll be able to fix it within Memento or upstream so I don't have to maintain this feature myself.

from memento.

ripose-jp avatar ripose-jp commented on June 22, 2024 1

Turns out the Windows build script was broken by a name change of a runtime dependency. Due to some misconfiguration the Windows build pipeline missed it. This lead to QtWinDeploy not copying QtSVG (I think), leading to the missing icons. I got a fix up on dev and I'll merge it to master when CI finishes.

Thanks for finding two actionable issues.

from memento.

ripose-jp avatar ripose-jp commented on June 22, 2024

the autoload script

I don't know what script you're talking about. Please link it.

I would like it to remember the playlist when exiting memento and resume where I left off when starting memento.

How is this different from mpv's built in watch later functionality? I don't really use playlists, so I wouldn't know what your workflow is, but from my understanding your position in a playlist is saved.

There are scripts for this but all of them seem to have the same problem of opening in a separate mpv window instead of playing in the memento window.

I've only seen this happen when the vo is set to something other than libmpv. I'm not saying this is the only reason this can happen, but it's the only reason I've seen so far. It would be strange for such a script to set the vo when loading a file though, so I really do want to see what script you're using.

from memento.

Issue-maker-9000 avatar Issue-maker-9000 commented on June 22, 2024

I don't know what script you're talking about. Please link it.

Autoload
"-- This script automatically loads playlist entries before and after
-- the currently played file. It does so by scanning the directory a file is
-- located in when starting playback. It sorts the directory entries
-- alphabetically, and adds entries before and after the current file to
-- the internal playlist. "

How is this different from mpv's built in watch later functionality? I don't really use playlists, so I wouldn't know what your workflow is, but from my understanding your position in a playlist is saved.

I also use the watch later functionality, but it only saves the playback position. You still have to navigate to the video manually to resume where you left off.
Even a list of last played videos would suffice, sadly scripts that add this functionality aren't accessible when memento is idle. (This differs from standard mpv where you can access historylists when the player is idle)

I've only seen this happen when the vo is set to something other than libmpv. I'm not saying this is the only reason this can happen, but it's the only reason I've seen so far. It would be strange for such a script to set the vo when loading a file though, so I really do want to see what script you're using.

The SimpleHistory script with "startup_idle_behavior" set to "resume" is what I am kinda looking for, but like I said a easy way to resume playback of the last played video is also something I would be happy with.

I've set vo to libmpv manually but same result as in the image, where the video plays in a separate window while the subtitles stay in memento.

memento

from memento.

ripose-jp avatar ripose-jp commented on June 22, 2024

You found a super interesting bug. Turns out SimpleHistory was observing the idle-active property. By default libmpv has idle=yes because otherwise the core would immediately exit. Since Memento initializes the mpv context before the mpv render context, the idle-active observer in SimpleHistory would trigger before mpv knew that the vo should be libmpv. This would lead to mpv assuming vo=gpu and opening a new window. The bug can be fixed by initializing the mpv context after the mpv render context.

I'll get a fix up shortly.

from memento.

Issue-maker-9000 avatar Issue-maker-9000 commented on June 22, 2024

Interesting. thanks so much for looking into it!
Just built master, all seems to work as expected. For some reason no icons showing up in my build but that is not that big of a deal. :P

from memento.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.