Comments (11)
JFYI: This is also a issue for the AUR package. Looking forward to a new release.
from memento.
I've updated the PKGBUILD in the AUR with a band aid that will fix the build until I get a new release out.
@teto Here's the change if you want to use it as a stopgap. It's apparently important that cmake -E env
be followed by a normal configure call to cmake
in the same command.
cmake -E env \
CFLAGS="-Wno-error=deprecated-declarations" \
CXXFLAGS="-Wno-error=deprecated-declarations" \
cmake ..
from memento.
Works fine, thanks!
from memento.
@teto v1.2.0 has just been published and I've removed -Werror
from the compiler flags so something like this doesn't happen again.
from memento.
Thanks for the report, but this has already fixed on master with 267e4a4
from memento.
is there going to be a release soon ? to know when to update the package
from memento.
The bug fixes since the last release are very minor and there's only one new feature. I don't see the point at the moment.
from memento.
Is it just a warning or is it actually preventing compilation?
I will say my opinion on making a new release has changed since I just found out that mpv made a new release in the past few weeks. Since most people use the Windows version, new releases of Memento are really the only way to get out new versions of mpv to those users.
from memento.
With the Archlinux aur package, build does fail, not just a warning. (because of -Werror=deprecated-declarations?)
.../memento/src/Memento-1.1.0/src/dict/yomidbbuilder.c: In function ‘extract_resources’:
.../memento/src/Memento-1.1.0/src/dict/yomidbbuilder.c:1878:5: error: ‘zip_get_num_files’ is deprecated: use 'zip_get_num_entries' instead [-Werror=deprecated-declarations]
1878 | for (zip_int64_t i = 0; i < zip_get_num_files(dict_archive); ++i)
| ^~~
In file included from .../memento/src/Memento-1.1.0/src/dict/yomidbbuilder.c:31:
/usr/include/zip.h:379:68: note: declared here
379 | ZIP_DEPRECATED("use 'zip_get_num_entries' instead") ZIP_EXTERN int zip_get_num_files(zip_t *_Nonnull);
| ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [src/dict/CMakeFiles/yomidbbuilder.dir/build.make:90: src/dict/CMakeFiles/yomidbbuilder.dir/yomidbbuilder.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:686: src/dict/CMakeFiles/yomidbbuilder.dir/all] Error 2
from memento.
Thank you (=
from memento.
@ripose-jp thanks. No one complained about the broken package yet so till it happens, I'll wait for a release.
from memento.
Related Issues (20)
- Kanji Stroke Order font HOT 1
- [Feature Request] Glossary Selection Marker HOT 12
- [Feature Request] Subtitle Delay HOT 3
- MeCab UniDic support HOT 3
- QT6 migration causes subtitle position to shift when on screen controller is shown/hidden HOT 1
- Lack of Styling on Anki Cards Added via Memento HOT 4
- jp mining note support HOT 3
- Setting secondary_sub_visibility to 'auto' within the mpvacious plugin does not work HOT 2
- Any configuration guide? HOT 1
- Jellyfin mpv shim? HOT 16
- Video does not play HOT 4
- Improve popup dictionary styling HOT 5
- Partially visible video when using display scaling HOT 4
- Auto-resume video after finishing hovering over words? HOT 1
- Some elements in subtitles search are larger than expected HOT 2
- Segmentation fault (core dumped) Error in Arch Linux HOT 4
- How to make word and furigana bigger on the word search HOT 1
- Segfault when using the new deconjugation matcher HOT 8
- How to hide progress bar in full screen? HOT 1
- video issue HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memento.