Transparent subtitle bug introduced in 4bb801f about memento

[ripose-jp]

Can you give me some steps on how to reproduce this?
I've used a version with that commit for a few weeks now and haven't run into any issues on Linux. I'm also not seeing any problems with the macOS version either.

[Calvin-Xu]

I finally found a reliable and portable way of reproducing this. Start Memento in windowed (not fullscreen) mode. Play this video from YouTube and select the Japanese subtitle. The subtitle widget displayed correctly. Fullscreen Memento, and the subtitle widget becomes transparent but still searchable on hover as described. Exit fullscreen and the widget continues to be transparent. A build on cb93730 does not have this bug.

Tested on macOS 12.0.1. Local and other videos are affected too (i.e., I downloaded the video and loaded it and could reproduce the bug).

[ripose-jp]

I don't have time to reproduce it right now, but if I had to guess it's going to be specific to macOS because updates are disabled when switching between fullscreen and windowed mode on macOS because Memento will hang otherwise. Since that code restores the old value of updatesEnabled, it is probably restoring a disabled value due to a race condition.
Rather than reverting the commit in question, I'll probably just ifdef the code out on macOS since it isn't strictly necessary. But this is just a guess pending further investigation. If it happens on other OSes, I'll revert it.

Thanks for the report.

[Calvin-Xu]

Thank you. I've read #7 before and understand that there have been issues with entering and exiting fullscreen on macOS. I am not able to test on other platforms at the moment but I think this is probably a good way of addressing this.