GithubHelp home page GithubHelp logo

Comments (2)

dhermes avatar dhermes commented on August 25, 2024 1

Sounds good! I need to implement a zerolog wrapper anyway. I'll avoid logging in my handler and just handle the Sentry parts there.

Cheers!

from river.

brandur avatar brandur commented on August 25, 2024

Hmm, I'm a little hesitant to make the behavior subtle to that degree, which may make it hard to understand/explain. I'd also suspect that there may be some users out there who would want the error logging even though they implemented ErrorHandler, and I don't think we'd want to add a specific configuration option to indicate whether you want one or the other.

@dhermes Have you considered either (1) redirecting the built-in slog logging to another target, or (2) disabling it in favor of your own logging? You can suppress it completely with something like:

Logger: slog.New(&slogutil.SlogMessageOnlyHandler{Level: 9}),

(This works because 9 > slog's error level.)

If you wanted logging on job completion etc, you could add a subscription where that happens.

from river.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.