Comments (2)
Sounds good! I need to implement a zerolog
wrapper anyway. I'll avoid logging in my handler and just handle the Sentry parts there.
Cheers!
from river.
Hmm, I'm a little hesitant to make the behavior subtle to that degree, which may make it hard to understand/explain. I'd also suspect that there may be some users out there who would want the error logging even though they implemented ErrorHandler
, and I don't think we'd want to add a specific configuration option to indicate whether you want one or the other.
@dhermes Have you considered either (1) redirecting the built-in slog logging to another target, or (2) disabling it in favor of your own logging? You can suppress it completely with something like:
Logger: slog.New(&slogutil.SlogMessageOnlyHandler{Level: 9}),
(This works because 9 > slog's error level.)
If you wanted logging on job completion etc, you could add a subscription where that happens.
from river.
Related Issues (20)
- Data race from tests
- InsertManyTx and scheduled_at HOT 7
- ColumnExists query breaks when there are multiple river queues across different schemas HOT 3
- RiverClient Init. Syntax Err HOT 1
- Getting available jobs uses an orphan context which loses important information passing HOT 2
- Cannot test work that inserts jobs using `river.ClientFromContext` HOT 7
- Allow customize context used in Work func with provided key/values in Insert HOT 3
- `FinalizedAt` struct field is not set on `Job` for cancelled events HOT 4
- Version in `go.mod` could be lowered HOT 4
- Background worker always uses public schema HOT 1
- Unable to install the CLI in v0.11.3 HOT 3
- [Feature request] Programatic migration HOT 3
- rivertest examples require internal package HOT 2
- Elector interval field value out of range HOT 8
- docs: riverpro missing line type workflows -> workflow HOT 3
- Graceful shutdown - StopAndCancel panics HOT 3
- [FEATURE REQUEST] Jobs aggregation HOT 6
- [FEATURE REQUEST] Jobs sequential run HOT 4
- [FEATURE REQUEST] provide helper to check if all jobs have been run during tests HOT 2
- Workflow - periodic unique workflow with cancelation HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from river.