Comments (4)
Ah, yeah we never got around to implementing this. We can either nuke the setting for now, or try to make the required fixes to make it work. I expect it will come up as a requested setting.
Even without explicit support for this, the user could already be setting a search_path
in the pgx.ConnConfig
RuntimeParams
and any conns we check out will already be configured to use the specified schema. So I'm not actually clear whether we need a setting for this even if we support it.
from river.
Actually, good point on using pgx to configure it — I kinda like that, although we'd definitely need a section in the docs explaining how to do it because it wouldn't be obvious.
The CLI migrator would probably still need to support a --schema
option, but the eventual more flexible rivermigrate
package that takes a pgx connection could use the pgx technique.
from river.
@brandur you can actually set search_path
as part of the connection URL if desired: jackc/pgx#1013 (comment)
So maybe the CLI already works with it too?
from river.
Oh awesome! Another thing we'll have to document because it's pretty non-obvious, but yes, that should solve our problems for now.
from river.
Related Issues (20)
- Cancelling periodic jobs question HOT 2
- Dead letter handling
- cmd/river: Exit code 0 on flag error HOT 1
- UniqueOpts with ByTags argument HOT 2
- Docs should make insert-only Client mode clearer HOT 5
- Editing job arguments and snoozing HOT 3
- [FR]: Job ordering HOT 1
- change default retry count HOT 1
- In which case, it will cause the 'INFO Notifier: Listener closing'? HOT 4
- flaky TestPeriodicJobEnqueuer
- Flaky unique inserter test HOT 2
- Dynamic queue handling HOT 3
- Python support for river? HOT 3
- panic: send on closed channel HOT 6
- Insert jobs from workers HOT 2
- Intermittently failing test: `TestPeriodicJobEnqueuer/AddAfterStart` HOT 3
- river hides panic stack traces in database HOT 6
- uniqueness does not work at scale HOT 2
- Batch processsing HOT 14
- when master does not have workers for queues it does not process, configured, the job rescuer loses jobs HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from river.