Comments (4)
Thanks @neilotoole, this has been bugging me since I set up the site and your comment reminded me to take care of it. Should be all good now ✨
from river.
FYI, the visible backticks come from Tailwind's typography plugin. It's a stylistic thing for sure, but I don't know, I think they look good.
https://tailwindcss.com/docs/typography-plugin
While you're in there... on the same page, I suspect you're missing the code fence on two links:
Fixed those two.
For the docs site for my main side project, sq, I enabled some Hugo setting, and it shows an Edit this page on GitHub link. E.g. if you scroll to the bottom of this page, you'll see a link:
Yeah, we might want to do that eventually. The docs repo is still in somewhat rough shape though, so we probably wouldn't make it public without an overhaul.
from river.
but I don't know, I think they look good.
I was in two minds about the ticks when I first saw them on the site, but whether or not the look has appeal, this...
![image](https://private-user-images.githubusercontent.com/6013203/305733014-d049907b-122c-473f-9e3c-9c90834556d6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwNTg0MDQsIm5iZiI6MTcyMDA1ODEwNCwicGF0aCI6Ii82MDEzMjAzLzMwNTczMzAxNC1kMDQ5OTA3Yi0xMjJjLTQ3M2YtOWUzYy05YzkwODM0NTU2ZDYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDRUMDE1NTA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZGI0MzUzM2M0ZGQ0NTdmNmU0MmY1Y2YyYjM2MDUxNzk2MjYwYWM2NmYzZWY2ODdjMjcxNDcxN2VkZWNlOTA5NCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.YDchvNKFVw1By2whiMNWm3dLG9ZK7FnKPNoabUZ63m4)
... is not a good outcome.
The docs repo is still in somewhat rough shape though, so we probably wouldn't make it public without an overhaul.
Roger that. I think it looks very solid overall fwiw 👍
from river.
this has been bugging me
@bgentry I would have been deeply disappointed if this critical issue hadn't been bugging you! 😜
While you're in there... on the same page, I suspect you're missing the code fence on two links:
![needs_code_fence](https://private-user-images.githubusercontent.com/6013203/305689299-6402c7c4-d4c0-4bb1-bfac-59cae7afb3ad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwNTg0MDQsIm5iZiI6MTcyMDA1ODEwNCwicGF0aCI6Ii82MDEzMjAzLzMwNTY4OTI5OS02NDAyYzdjNC1kNGMwLTRiYjEtYmZhYy01OWNhZTdhZmIzYWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDRUMDE1NTA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Mzk2NzliMDYxN2U3ZThhMzM2ODk4ODFhODIyZGVmODQ4OTY1OWRiM2FjNWViZDZiZDIyYzVlYTIwNGE1YWMwMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.MBl2_o6_LzRWmFiMfaoRuz9ilxudmMUMtaQSGsIEzRA)
In the interest of not consuming all your time: I imagine you're using some sort of static site generator like Hugo, backed by a GH repo? Have you considered making that repo public so PRs can be submitted?
For the docs site for my main side project, sq, I enabled some Hugo setting, and it shows an Edit this page on GitHub link. E.g. if you scroll to the bottom of this page, you'll see a link:
![sq_edit_on_github](https://private-user-images.githubusercontent.com/6013203/305689531-b3425a2b-34c2-46a8-afe9-8b17db6c9d20.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwNTg0MDQsIm5iZiI6MTcyMDA1ODEwNCwicGF0aCI6Ii82MDEzMjAzLzMwNTY4OTUzMS1iMzQyNWEyYi0zNGMyLTQ2YTgtYWZlOS04YjE3ZGI2YzlkMjAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDRUMDE1NTA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTFiY2NjZDg0Njg0NjI0NTYzYWNhNTNiZmY1YjBhMmQwYzcwODA5MjdmNzcyOWUzZTVjNTM5MmY4NDIyNGFjMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.VMbn84DOJUTnyPBwUAzA3PusceSQV9vrZj8UBY-DEug)
from river.
Related Issues (20)
- Submit jobs without doing work? HOT 1
- Question: How to approach testing / mocks
- Periodic Jobs question HOT 4
- Cancelling periodic jobs question HOT 2
- Dead letter handling
- cmd/river: Exit code 0 on flag error HOT 1
- UniqueOpts with ByTags argument HOT 2
- Docs should make insert-only Client mode clearer HOT 5
- Editing job arguments and snoozing HOT 3
- [FR]: Job ordering HOT 1
- change default retry count HOT 1
- In which case, it will cause the 'INFO Notifier: Listener closing'? HOT 4
- flaky TestPeriodicJobEnqueuer
- Flaky unique inserter test HOT 2
- Dynamic queue handling HOT 3
- Python support for river? HOT 3
- panic: send on closed channel HOT 6
- Insert jobs from workers HOT 2
- Intermittently failing test: `TestPeriodicJobEnqueuer/AddAfterStart` HOT 3
- river hides panic stack traces in database HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
snippets.
from river.