Goroutine started by Fanin method is not closed between the tests. about notify

[ppknap]

This is not a platform-dependent issue and should be handled by your runtime's implementation. Sorry @rjeczalik, but without a fix I cannot move things forward.

[rjeczalik]

There's already work on this here 6221e74. The end result is every Watcher implementation is initialised by NewWatcher, meaning inotify, fsevents etc. implement func newWatcher() Watcher.

The fact inotify is half-global now does not help, since there's not way to control the moment of initialisation. For tests there'll be no default runtime initialized.

It would help if all inotify context could be bound to inotify struct.

[ppknap]

If you want to have one object which handles all watched directories it's better to use it since a very beginning of the implementation. It should be possible to run multiple tests (even with t.Parallel()) on one watcher/runtime instance. Or, did I miss something when you were speaking about including "newWatcher" to the public interface;>

[rjeczalik]

Actually nvm, it will work despite what I said. I'll send PR in couple of minutes.

[rjeczalik]

@ppknap see #29 and ok me when no issue with merging it

[ppknap]

LGTM 💛