Upgrade to latest NTPClient lib once stable 3.x.x release is available. about esp8266-react

[beta-tank]

Hi, thanks for your project. I am new here and I’d like to know about the benefits of using the NTPClient library.
I use the default implementation from sntp.h and there are no problems.
Initialization can be done like this:

 configTime(7 * 3600, 0, "time.google.com");

or you can manually call all init functions:

sntp_stop();
sntp_setserver(0, "time.google.com");
sntp_set_timezone(7);
sntp_init();

Then you should wait for the time initialization to happen. I make it in the setup function in a synchronous way (because my functionality needs the actual time), but it can be made in the loop in an async way with a callback.
Here is my implementation, fairly straightforward:

time_t getTime(){
  #ifdef ESP8266
    return sntp_get_current_timestamp();
  #endif
  #ifdef ESP32
    time_t now = 0;
    return time(&now);
  #endif
}
int last = 0;
  while(getTime() < 1500000000){
    if((millis () - last) > 1000){
        last = millis ();
        Serial.println(getTime());
        Serial.println("Waiting for sntp.");
    }
    yield();
  }

[rjwats]

Gmag's NTP client implementation provides a refresh interval and retry-on-failure behaviour on top of the network level NTP handler.

…

On Fri, Jun 14, 2019 at 8:36 AM Evgeniy Komissarov ***@***.***> wrote: Hi, thanks for your project. I am new here and I’d like to know about the benefits of using the NTPClient library. I use the default implementation from sntp.h and there are no problems. Initialization can be done like this: configTime(7 * 3600, 0, "time.google.com"); or you can manually call all init functions: sntp_stop(); sntp_setserver(0, "time.google.com"); sntp_set_timezone(7); sntp_init(); Then you should wait for the time initialization to happen. I make it in the setup function in a synchronous way (because my functionality needs the actual time), but it can be made in the loop in an async way with a callback. Here is my implementation, fairly straightforward: time_t getTime(){ #ifdef ESP8266 return sntp_get_current_timestamp(); #endif #ifdef ESP32 time_t now = 0; return time(&now); #endif } int last = 0; while(getTime() < 1500000000){ if((millis () - last) > 1000){ last = millis (); Serial.println(getTime()); Serial.println("Waiting for sntp."); } yield(); } — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#14?email_source=notifications&email_token=AAKE4VEHEA5RIY7MH2EBHSLP2NC7TA5CNFSM4HIILQLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXV7MXI#issuecomment-502003293>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKE4VCDE5ZMH3YCS3JFNGTP2NC7TANCNFSM4HIILQLA> .

[beta-tank]

Thanks for the explanation. I'll try to use NTPClient library in my project to simplify the migration to your react framework.

[proddy]

SNTP is now native in the ESP8266 and ESP32 arduino core. See #47 (comment). After the PR has been merged you can close this

[rjwats]

Won't do - sntp support now implemented