Comments (7)
I do not think these files belong in the core lush project because:
-
They'll actually end up pretty hidden away for people who want to find them ("just cp .local/nvim/site/packer/compiled/lush.nvim/... ..." bleh)
-
They might end up with frequent changes or "upstream plugin changed" patches which will clutter lush's mainline git log.
I think they either go into:
- https://github.com/rktjmp/lush-template (I think I would prefer to keep this as blank/light/unintimidating as possible)
- an as yet non-existent https://github.com/rktjmp/lush-template-...plugin-starters? or something
- a kunzaatko/lush-plugin-starters repo.
I don't think I mind hosting a starter/helper repo, probably mostly just a matter of deciding on a format and writing a readme on what they are and how to use them.
from lush.nvim.
Maybe they could be added as a submodule to the https://github.com/rktjmp/lush-template.
from lush.nvim.
Isn't that just including them directly but with extra steps?
At any rate. I think they should by default be:
- one rule per line
- commented out
So someone can grab the file and just update whatever parts they need without clearing any existing highlight links setup by the plugins.
How/where are you generating these from?
from lush.nvim.
Isn't that just including them directly but with extra steps?
I think that i order to download the submodules, you have to have write git submodule update
to fetch them. That makes it opt-in rather then opt-out...
- one rule per line
- commented out
Sure, that is sensible.
How/where are you generating these from?
I just grabbed some big colourschemes, concatenated them, sorted them, filtered them and then edited the result with some vim macros. This inherently means, that the list of groups is not necessarily exhaustive...
I will make a private repo and invite you. Then, when it gets stable and we figure out the specific layout, we can make it public and figure out where to put it (or if I should transfer ownership to you or something)...
from lush.nvim.
You can look at the new repo I created. It should work with the new extends
/with
API hopefully. @rktjmp
from lush.nvim.
Just thinking out loud,
the starter template could actually have multiple branches by default
- main/master/slim/default -> whats there now
- light_dark -> light dark variant template
- plugins -> has the plugins
You could probably start main then just merge in what you want git merge light_dark
git merge plugins
.
What I want to avoid is someone cloning down that repo, seeing 1000 files and thinking Lush is really heavy and complex when it really isn't.
from lush.nvim.
That seems reasonable. I think that it should also be emphasized in the README that the plugins are really templates and there is no need to implement a lot of them... So the template should then be in one repo not two as we agreed upon before...
from lush.nvim.
Related Issues (20)
- Unreliable Lushify behaviour HOT 1
- Using new Treesitter groups/tags HOT 4
- How to specify treesitter highlight groups? HOT 2
- How to define treesitter `@x.y` groups HOT 14
- Transparent function HOT 4
- separate colors for keywords and brackets in JavaScript? HOT 3
- Theme the nvim-cmp HOT 2
- `:LushImport` broken HOT 5
- `:Lushify` doesn't work with `lush.extends()` HOT 2
- Built-in support for `g:terminal_color_*` variables HOT 1
- Following the guide to configure an existing theme removes icon colors HOT 7
- Changing boilerplate `sed` code results in error in Mac HOT 4
- `Cursor` highlight group appears not to be working HOT 1
- HSV support ? HOT 2
- `LushImport` doesn't work and errors saying bad argument HOT 3
- slow startup time HOT 8
- Cannot add colour variation for filetype sh HOT 4
- Add warning in :LushRunTutorial to avoid loss of work with naive `:w`'s HOT 1
- Error `bad argument #1 to 'unpack' (table expected, got nil)` HOT 8
- altfont style support is missing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lush.nvim.