GithubHelp home page GithubHelp logo

Comments (2)

rmax avatar rmax commented on May 27, 2024

At the time, request_from_dict required several keys as you can see here. And the need was to load start URLs from redis, which initially were just URL strings, and then changed to dict-like with url, method and meta which were the fields some users needed.

I'm not sure if current request_from_dict can replace current approach seamlessly, feel free to contribute!

from scrapy-redis.

LuckyPigeon avatar LuckyPigeon commented on May 27, 2024

IMO, we don't need request_from_dict at the moment. The very first concept of make_request_from_data is making our request more flexible, on the other hand, request_from_dict is letting users define and pass their own request class.

For the above reason, I don't think that we should add request_from_dict now. But discussions are welcome, and feel free to contribute.

from scrapy-redis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.