Need to be able to set `sandbox` property to empty string about react-iframe

[robbestad]

Good idea, will implement! man. 24. sep. 2018 kl. 19:18 skrev gtwilliams03 <[email protected]>:

[Edit] This does allow setting the sandbox property to "something" but it does not allow the value to be empty. I question whether a blank sandbox value should be the default? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABfQp4rdoYGl7ijzzh1IQ4WvYpfXamVMks5ueRP_gaJpZM4W3GBa> .

-- Mvh, Sven Anders Robbestad https://www.robbestad.com <http://www.robbestad.com/>

[gtwilliams03]

[Edit] This does allow setting the sandbox property to "something" but it does not allow the value to be empty. I question whether a blank sandbox value should be the default?

[gtwilliams03]

I have run into issues displaying PDFs in an iframe with various plugins even with sandbox='' - so it might even be preferable to also support a sandbox={false} property (which does not render the sandbox property at all. I just ran into this yanking react-iframe out of a project and replacing it with basic <iframe> tags (I had to remove the sandbox property altogether from the basic HTML iframe tag).

[robbestad]

Alright! Fixed in 1.3.2! tor. 27. sep. 2018 kl. 16:51 skrev gtwilliams03 <[email protected]>:

I have run into issues displaying PDFs in an iframe with various plugins even with sandbox='' - so it might even be preferable to also support a sandbox={false} property (which does not render the sandbox property at all. I just ran into this yanking react-iframe out of a project and replacing it with basic <iframe> tags (I had to remove the sandbox property altogether. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABfQp0W_RiRFUhoYvpNby5xF0AEgIZtpks5ufOXYgaJpZM4W3GBa> .

-- Mvh, Sven Anders Robbestad http://www.robbestad.com http://twitter.com/#!/svenardocom

Thanks! I ran into this just this morning, found this issue, came back ten minutes later and it was fixed. Excellent work.

FWIW, this also allows you to run flash, which was my hurdle.

[gtwilliams03]

I updated and all is well with me! Many, many thanks!