GithubHelp home page GithubHelp logo

Comments (5)

thierrymichel avatar thierrymichel commented on June 12, 2024

Hi,

FYI, same problem with 2.2.2 and 2.2.1. But works perfectly with 2.2.0…

from dropkick.

Robdel12 avatar Robdel12 commented on June 12, 2024

Sorry about this! It's related to changing the main in package.json. It's now pointing to the complied version because before you would have to transpile the ES6 class in your build system -- which wasn't ideal.

But now it seems there's issues with the file that's built. It's not doing the right "module dance" (AMD vs commonjs vs commonjs2 vs root). Fix one bug, create another 😅 I started to take a look at this over the weekend but ran out of time.

Where I left off was dorking with the webpack config to compile umd, but it still left me with the same issue. I'm going to try and find more time this week to try and tackle this. Distributing JS is hard :/

from dropkick.

thierrymichel avatar thierrymichel commented on June 12, 2024

No problem, great job. :)
It should work with something like this: https://webpack.js.org/configuration/output/#output-librarytarget
I still have strange behavior between dev/watch and production/build (with UglifyJS 2 or 3).
I will try to investigate also on my side.

from dropkick.

thierrymichel avatar thierrymichel commented on June 12, 2024

I had no time to dig into this issue.
If it can help, here is my last package which correctly exposes module and browser (package.json)

For now, temporarly fixed with: import Dropkick from 'dropkickjs/src/dropkick';

from dropkick.

Robdel12 avatar Robdel12 commented on June 12, 2024

Hey everyone! I finally had some time to sit down and figure out what was going on. Basically don't have multiple webpack entries 😰

Give v2.2.3 a try and let me know :)

from dropkick.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.