Any file return one message about node-mbox

[robertklep]

Easy solution: only feed it mbox files 😉

But I get your point. The issue is that even if a file starts with From, it doesn't necessarily have to be an mbox file anyway. So I could have it check for that header, but perhaps it should just assume that anything that gets passed through it is a valid mbox file (like it does now).

[misteral]

Hi, but blackbox.psd not have 'From' string in fact. How i can check what the file is have mbox format? I think if mbox-npm return 0 messages - is not a mbox file.

[robertklep]

Strictly speaking, node-mbox is meant to parse mbox files, not to check if a file is a valid mbox file. I'll add a "strict" mode that you can enable which will cause an error to be thrown when the input doesn't start with From, does that sound reasonable?

— robert (iPad)

On 27 mrt. 2016, at 12:29, Александр [email protected] wrote:

Hi, but blackbox.psd not have 'From' string in fact. How i can check what the file is have mbox format? I think if mbox-npm return 0 messages - is not a mbox file.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

[robertklep]

@misteral I pushed an update, if you care to test it:

npm i robertklep/node-mbox#59899c6

The two main changes:

• it should return a message count of 0 for non-mbox files (however, strictly speaking, if it finds the string \nFrom anywhere in the file, it may still think it found a message meaning files that don't start with From);
• there's an option strict that will cause an error event to be thrown if the input doesn't start with From;

If it works as expected, I'll publish it as v0.3.0.

[misteral]

Yes, it works! Thanks. Please release v0.3.0

[robertklep]

Done!