GithubHelp home page GithubHelp logo

Comments (3)

RobertMyles avatar RobertMyles commented on May 19, 2024

Looking at this again, @chainsawriot , I think feeds like this are either uncommon or shouldn't be the target of parsing, so I don't want to customise tidyRSS to handle something like this.

from tidyrss.

chainsawriot avatar chainsawriot commented on May 19, 2024

@RobertMyles Fine.

For this project, we check around 1000 RSS every few hours and around 10% of them are having this error. So, feeds like this are actually not that uncommon at least in our application. It's an edge case for sure. But I think it would be better to tell users this is an edge case. Those are valid feeds; if the "contract" in the documentation is hold, it should return an empty tibble / list.

tidyRSS/R/tidyfeed.R

Lines 18 to 20 in 1a4c5fc

#' @description \code{tidyfeed()} downloads and parses rss feeds. The function
#' produces either a tidy data frame or a named list, easy to use for further
#' manipulation and analysis.

Even if no tibble is gonna returned, a more informative error message (e.g. "No parsable item in this feed") is helpful even when it raises an error.

If you want that, I can submit a PR.

from tidyrss.

RobertMyles avatar RobertMyles commented on May 19, 2024

Sure, I hadn't realised feeds like this are that common, did really seem like an edge case to me and I'm reluctant to try and adapt the package to all the messed-up feeds that can be found in the wild (I tried that before). Happy to receive a PR if you'd like to do that, I may not get around to doing this myself for a while.

from tidyrss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.