Comments (7)
Comment by robertwb on 23 May 2008 02:55 UTC
I'm not quite sure I understand--if MS_WINDOWS is defined, then isn't __stdcall defined as well?
from issues-import-test.
Comment by JimKleckner on 23 May 2008 03:23 UTC
Correct.
That is why the stub for !__stdcall is protected by an
#ifndef MS_WINDOWS
so that it won't blow it away in that case.
The issue is that Python.h doesn't include <windows.h> so that
when the conditions are processed, !__stdcall will not yet
be defined. In that case, we need to protect it with the platform
define.
In the DllMain embedding I'm playing with, I explicitly include
windows.h which then causes it to become defined. Without the
protection of MS_WINDOWS, it has already been made into an empty
string value.
from issues-import-test.
Comment by JimKleckner on 25 Jul 2008 16:27 UTC
I just spent a couple of hours tracking down a linkage problem after updating my tool chain because I forgot about this patch that never got applied.
One can argue that this is major if you are trying to build something on Windoze because linkage fails.
Please either apply the patch or tell my why you won't.
from issues-import-test.
Comment by JimKleckner on 25 Jul 2008 17:22 UTC
Attached is an updated patch that also defines _USE_MATH_DEFINES so that
M_PI and such will get defined as with the standard math.h.
from issues-import-test.
Modified by robertwb on 3 Aug 2008 06:45 UTC
from issues-import-test.
Comment by robertwb on 15 Aug 2008 08:58 UTC
Sorry it has taken so long, I don't have Windows to test this on, and no one has stepped up to do the same. (Also, it was marked as "minor" so it slipped under the radar for a while.)
Thank you for the patch, it's in now.
from issues-import-test.
Modified by robertwb on 19 Aug 2008 03:59 UTC
from issues-import-test.
Related Issues (20)
- Cannot use "except" with complex numbers
- Support patchless backports_abc HOT 3
- Getting unbound method returns descriptor instead of unbound method
- cimported ctuples don’t compile their declaration
- cythonize doesn’t recompile when only the pxd has changed in pure python mode
- Inefficient unpacking of std::pair
- False "Unreachable code" warning HOT 3
- Conversion error from __PYX_VERIFY_RETURN_INT on 32bit systems HOT 6
- pxd files for posix and libc should use system includes HOT 1
- Illegal C code generated with numpy complex type HOT 1
- Combining @staticmethod with other decorators is broken
- cycache fingerprint does not look at compiler directives and Cython version HOT 2
- cycache fingerprint does not look at compiler directives and Cython version HOT 2
- Support extension type inheritance in pure python mode (@cclass) HOT 1
- Support extension type inheritance in pure python mode (@cclass) HOT 1
- Support extension type inheritance in pure python mode (@cclass) HOT 1
- Support extension type inheritance in pure python mode (@cclass) HOT 1
- Support extension type inheritance in pure python mode (@cclass) HOT 1
- Support extension type inheritance in pure python mode (@cclass) HOT 1
- Support extension type inheritance in pure python mode (@cclass) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from issues-import-test.