GithubHelp home page GithubHelp logo

Comments (8)

PeterBowman avatar PeterBowman commented on June 9, 2024 3

ASWJ:

  • Examples are going to remain as self-contained projects, no matter what.
  • We could instruct root CMakeLists.txt to traverse these project so that everything is built together (main project + examples). However, this simple trick would force us to hide a few lines behind an if clause, for instance these find_package() instructions. Since we aim to illustrate best practices and usage of our libraries/APIs (targeted at devs), such hacks would be certainly misleading.
  • Make Travis configure and compile the examples separately in the before_script section of .travis.yml.

from questions-and-answers.

PeterBowman avatar PeterBowman commented on June 9, 2024 1

Added TODO list to description.

from questions-and-answers.

PeterBowman avatar PeterBowman commented on June 9, 2024 1

Several examples are not even written in C/C++. Perhaps we could test bindings, too.

from questions-and-answers.

PeterBowman avatar PeterBowman commented on June 9, 2024

We could have avoided roboticslab-uc3m/tools#10 (comment) if examples were covered by tests.

Also, keep this in mind: roboticslab-uc3m/developer-manual#21. Which boils down to: place Travis instructions that relate to building the examples in the before_script YAML section.

from questions-and-answers.

PeterBowman avatar PeterBowman commented on June 9, 2024

CMake alias targets may be useful here.

from questions-and-answers.

PeterBowman avatar PeterBowman commented on June 9, 2024

Idea: add_subdirectory(examples) from root CMakeLists.txt, set ENABLE_examples=ON in Travis (defaults to OFF)?

from questions-and-answers.

jgvictores avatar jgvictores commented on June 9, 2024

IMHO:

  1. CI is great, and it would be great to have examples at least compiled via Travis.
  2. I'm happy with self-contained examples. If we add_subdirectory(examples), wouldn't it be catching repo-level dependencies rather than forcing them to be cited explicitly?

As a solution, maybe forcing Travis to enter examples and compile separately?

from questions-and-answers.

jgvictores avatar jgvictores commented on June 9, 2024

@PeterBowman Thanks!!!

from questions-and-answers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.