GithubHelp home page GithubHelp logo

Comments (17)

dabertram avatar dabertram commented on June 24, 2024

this was a recent issue.. don't worry, you'll solve it ;-) 

Von Samsung Mobile gesendet

Peter Polidoro [email protected] hat geschrieben:

I am running Groovy on Ubuntu 12.04. I just apt-get upgraded my ros-groovy packages (to version 0.5.4-0precise-20140417-0429-+0000) and now code that used to work fine is suddenly broken. I am simply publishing an empty message on a topic from javascript using roslibjs (revision 6) and subscribing with a smach_ros.MonitorState. I get the error: "init() got an unexpected keyword argument 'queue_size'". I have tried several versions of roslibjs, so I assume the problem might lie with recent changes in rosbridge. I wish I had never run 'apt-get upgrade' as everything was working well before I did. Any suggestions on how to fix this error or how to revert back to previous versions of ros-groovy packages that were working before? Thanks!


Reply to this email directly or view it on GitHub.

from rosbridge_suite.

jihoonl avatar jihoonl commented on June 24, 2024

hm.... seems like deb is broken at the moment. I will see this problem sometime tomorrow. Does it happen to hydro deb as well?

from rosbridge_suite.

jihoonl avatar jihoonl commented on June 24, 2024

#86 This pull request might be related.

Try to 0.4.5 which is the previous deb of groovy version which should work.

from rosbridge_suite.

jihoonl avatar jihoonl commented on June 24, 2024

Can you share a simple example that I can test? I couldn't replicate the problem by myself yet. I found the error bug in current release though :P

In the meantime, I will re-release old version of rosbridge deb sometime tomorrow.

from rosbridge_suite.

peterpolidoro avatar peterpolidoro commented on June 24, 2024

Thanks for looking into this for me! Just re-releasing the old version of the rosbridge deb would be great since that used to work just fine for me. I can work on creating an example for you run, but basically all my code is doing is sending a message from javascript (please excuse formatting flaws):

var saveImage = new ROSLIB.Topic({
        ros : ros,
        name : '/controls/save_image',
        messageType : 'std_msgs/Empty'});
var emptyMsg = new ROSLIB.Message({});
saveImage.publish(emptyMsg);

And a smach monitorstate is receiving the message:

def monitor_cb(ud, msg):
    return False
smach.StateMachine.add('WAIT_TO_SAVE_IMAGE',
                                         smach_ros.MonitorState("/controls/save_image",
                                                                                 Empty,
                                                                                 monitor_cb),
                                         transitions={'invalid':'SAVE_IMAGE',
                                                            'valid':'aborted',
                                                            'preempted':'preempted'})

Is that enough information for you to create a test case?

from rosbridge_suite.

jihoonl avatar jihoonl commented on June 24, 2024

I have created PR to release old version which does not have queue_size. I will try to investigate this when I have time.

And thanks @peterpolidoro it would be sufficient. I have not played with smach though.

from rosbridge_suite.

peterpolidoro avatar peterpolidoro commented on June 24, 2024

Still getting the same error. Any idea when the deb packages might get fixed?
Package: ros-groovy-rosbridge-suite
Version: 0.5.4-0precise-20140503-0100-+0000
Architecture: amd64

from rosbridge_suite.

Alminc91 avatar Alminc91 commented on June 24, 2024

Hello,
I am get exactly the same error as peterpolidoro.
My system OS is Ubuntu 12.10 and ROS version is Groovy.

I am only trying to send a simple teleoperations message from the teleop widget in the RMS to the basic ROS turtlesim environment, so I can move the turtle.

I noticed in the groovy devel section of github you downgraded the package to 0.4.5 like mentioned.
https://github.com/RobotWebTools/rosbridge_suite/tree/groovy-devel

However, I followed the link on the ROS Wiki Instructions to install the deb package:
http://wiki.ros.org/rosbridge_suite/Tutorials/RunningRosbridge

It seems the version number of the rosbridge suite is still 0.5.4.

I hope you can fix this issue in the near future.
Otherwise is it possible to build 0.4.5 from source?
Thanks!

from rosbridge_suite.

rctoris avatar rctoris commented on June 24, 2024

@Alminc91 0.5.5 is what should be used. It is currently submitted to the build farm and we are awaiting a sync to the public repos. In the meantime, I think the branch got moved here: https://github.com/RobotWebTools/rosbridge_suite/tree/stable_release You should be able to use that from source.

@jihoonl Why is there a new branch stable_release? This seems confusing as why master and stable_release would be different. Master doesn't seem to match what is released.

from rosbridge_suite.

sosentos avatar sosentos commented on June 24, 2024

"@jihoonl Why is there a new branch stable_release? This seems confusing as why master and stable_release would be different. Master doesn't seem to match what is released."

+1 I have been having a hard time with that difference as well.

from rosbridge_suite.

jihoonl avatar jihoonl commented on June 24, 2024

Sorry about that. I was not sure how I should release the old version with higher version bump without corrupting master and develop branch sync.

Only way I can think of was deleting master branch and recreating it with old version tag, which I tried to avoid. Do you have any suggestion? Would it be better to recreate master branch with current release?

from rosbridge_suite.

jihoonl avatar jihoonl commented on June 24, 2024

I have released it with master branch. Sorry for confusion.

ros/rosdistro#4254
ros/rosdistro#4255
ros/rosdistro#4256

from rosbridge_suite.

jihoonl avatar jihoonl commented on June 24, 2024

The problem was the new feature queue_size in rospy.Publisher which introduced only after hydro distribution in ros/ros_comm#372. That is why rosbridge works in hydro and indigo, but not in groovy.

And rosbridge_suite releases all three distributions(groovy, hydro, indigo) with one shared branch which queue_size patch applied by the pull request #86

from rosbridge_suite.

jihoonl avatar jihoonl commented on June 24, 2024

Hm.. ok Conclusion.

Groovy uses groovy-devel branch to maintain the release.
Hydro and indigo will get re-released using up-to-date code using master branch.

from rosbridge_suite.

jihoonl avatar jihoonl commented on June 24, 2024

Is everyone ok with this?

from rosbridge_suite.

Alminc91 avatar Alminc91 commented on June 24, 2024

Yeah sure.
I got it working again compiling the last master branch commit with version 0.5.5 with groovy.
Thanks.

from rosbridge_suite.

jihoonl avatar jihoonl commented on June 24, 2024

Fixed and all are in public now.

from rosbridge_suite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.