GithubHelp home page GithubHelp logo

Comments (5)

rctoris avatar rctoris commented on July 22, 2024

My vote is to keep the failing build... since, technically, it is failing. Otherwise, the only thing Travis is doing, is verifying the package.xml files since there is no C++ to compile.

from rosbridge_suite.

jihoonl avatar jihoonl commented on July 22, 2024

Um.. I was worrying about accepting the future pull requests. Since travis will fail regardless of patch, the patch sender may get confused. (e.g. I accepted the pull requests then received e-mail indicates it failed in travis.... )

So I thought it would be better to keep it as issue and let travis success.

from rosbridge_suite.

rctoris avatar rctoris commented on July 22, 2024

Hmmm, I see your point. Okay, let's actually try and to figure out what's going on with these tests. So we can disable it for now but lets make a goal a week from Thursday the tests should be fixed. We can all take a look at them over that period. Thoughts?

from rosbridge_suite.

jihoonl avatar jihoonl commented on July 22, 2024

Sure. Let's disable it for now but take a look why it is failing. And fix :)

from rosbridge_suite.

jihoonl avatar jihoonl commented on July 22, 2024

It has been fixed in develop branch. Now travis invokes rostest again. Great thanks to @syrnick related PR : #111 #112

from rosbridge_suite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.