Demo Always fails. about twofactorauth

[toddmcbrearty]

I believe i found the problem.
In the demo you have

($tfa->verifyCode($secret, $code) === true)

verifyCode function returns 0 or 1 so that would obviously fail is it's not exactly equal to true.
You can either change === to == or i think it's better to return verifyCode as a bool

return (bool) result

[RobThree]

Was just looking into it; verifyCode should return a bool. Will fix in a few minutes.

[toddmcbrearty]

great! thanks.

[toddmcbrearty]

if it's easier for you i can do a pull request

[RobThree]

e837caa 😁

I've also created a new release.

Thanks for reporting it! 👍

[DanieleSassoli]

Hi, this got me confused this morning, luckly I saw this issue... I installed the package from composer (composer require robthree/twofactorauth) and it installed version 1.1, I tried telling composer to install version 1.2(which fixes this issue), with composer require robthree/twofactorauth:1.2 but composer stated that it coulnd't find any versione with that The requested package robthree/twofactorauth 1.2 could not be found.. I can't see what I'm doing wrong so maybe there's some sort of problem with the release...

[RobThree]

Whoops... forgot to update composer.json. I have created a new release 1.3 which should work (probably should've been a minor 1.2.1 or something but what the hell... 😜 )

[DanieleSassoli]

yep, fixed, thank you...

[RobThree]

👍