GithubHelp home page GithubHelp logo

Comments (6)

MiliAxe avatar MiliAxe commented on May 29, 2024

Update: pressing alt shows the tabs but incorrectly, sorry I couldn't capture a screenshot of it. Also, this works fine with
version 107.0b2 but not with the latest version of 108.0b3

from firefox-minima.

MiliAxe avatar MiliAxe commented on May 29, 2024

Update: After tinkering with the code, I noticed that adding the --tab-min-height to :root fixed the problem:

:root {
	--tab-font-size: 0.8em; /* Font size of the tab labels */
	--tab-font-family: "JetBrains Mono"; /* The font used for the tab labels */
	--max-tab-width: none; /* The maximum width a tab in the tab bar can use. Set this to none for no limit */
	--show-titlebar-buttons: none; /* Hide the buttons (close/minimize/maximize) in the title bar. Required on some platforms (e.g macOS) to fully hide the title bar. `none` hides them, `block` shows them */
	--tab-min-height: 10px !important;
}

but one other problem occured:

When I close tabs, my tabs seem to have added some sort of margin and they get disoriented:
out
(The GIF is sped up, the margins disappear after a few seconds of closing the tabs)

I noticed that his happens with this CSS:

.tabbrowser-tab[fadein]:not([pinned]) {
	max-width: var(--max-tab-width) !important;
}

from firefox-minima.

rockofox avatar rockofox commented on May 29, 2024

Hmm, I remember something similar happening when they added that little "view" button left of the tab bar.

I will get onto it asap

from firefox-minima.

MiliAxe avatar MiliAxe commented on May 29, 2024

It might be worth adding that when there are too many tabs added, with the addition of the "arrow" button (on the left in my screenshot), the tabs get disorganized again. It might be related to that?
image

from firefox-minima.

rockofox avatar rockofox commented on May 29, 2024

I just made an update that should fix the issues with the disorientation (and polishes a few other things).

  • I removed the "arrow" button, as it breaks the layout and doesn't really fit my vision anyway.
  • The issue with the margin that disappears after a few seconds is known. It is related to Firefox's animations. I personally have them disabled anyway, and that fixes the issue too (can be done by setting ui.prefersReducedMotion to 1 in about:config or by enabling "Reduce Motion" (or equivalent) in your operating system).

If any of those points bother you, feel free to open separate issues. I don't deem those as super important things, but I can take a look at it over long term if someone really cares enough ;)

from firefox-minima.

MiliAxe avatar MiliAxe commented on May 29, 2024

Thanks so much for the update! This fixed the problem and the user experience is way better. Have a great day.

from firefox-minima.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.